Coder Social home page Coder Social logo

Comments (5)

jplatte avatar jplatte commented on May 28, 2024

Actually, this seems even worse. Do these have to be valid credentials for the tests to pass?

from rust-s3.

durch avatar durch commented on May 28, 2024

@jplatte yeah, I did not have the bandwidth to mock the tests. Github actions associated with the repo pull in those secrets, if I recall correctly they get pulled into forked repo actions as well.

from rust-s3.

durch avatar durch commented on May 28, 2024

Actually judging by the output of that PR they don't, now that is extra crappy, I'll pull your branch over to test

from rust-s3.

durch avatar durch commented on May 28, 2024

@jplatte thank you for raising this, sorry for the crappy PR experiance, I'll have to figure something out here. I've merged your bumps, its published to crates.io as 0.24.0, I'll keep this issue open.

from rust-s3.

jplatte avatar jplatte commented on May 28, 2024

If they were available to PR branches, they could be leaked through PRs that update the actions workflow.

Maybe you could add a realworld-tests cargo feature and add #[cfg(not(feature = "realworld-tests"), ignore] to these tests (+ update your CI config to pass --features realworld-tests).

from rust-s3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.