Comments (4)
@gkelly Can you confirm you are using Python 3? I can replicate this issue with Python 3.8.5 but not with 2.7.18. On Python 2 I get only one Host header. If possible, could you see if you get the same result for Python 2?
from duo_client_python.
Yes, I am using Python 3. I just tested this in Python 2.7.14 and did not see the same double-Host-header behavior. However, I also tested #145 in Python 2.7.14 and it does not remove the lone Host
header. That is, the request looks correct with the patch applied:
POST /auth/v2/auth HTTP/1.1\r
Host: localhost\r
Accept-Encoding: identity\r
Content-Length: 22\r
Date: Wed, 02 Jun 2021 19:15:49 -0000\r
Content-type: application/x-www-form-urlencoded\r
Authorization: Basic <removed>\r
User-Agent: Duo API Python/4.3.1\r
\r
async=1&factor=testing
from duo_client_python.
I agree. So it seems the Py2 behavior of HTTPConnection is:
"Add a Host header if it's not already there"
Where Py3 is
"Add a Host header"
from duo_client_python.
Merged! We'll try to get a release done ASAP.
Thanks for the contribution and thanks for using Duo.
from duo_client_python.
Related Issues (20)
- Add Support Create Integration for SSO type HOT 5
- Update Admin cannot update the status HOT 1
- Deprecated SSL protocol in CertValidatingHTTPSConnection HOT 4
- Interators not working due to not having metadata populated HOT 5
- 403 Forbidden Access on all methods of Admin API HOT 6
- Duo: no library to generate passcodes HOT 4
- get_authentication_log - api:v2 param filter failing HOT 4
- metadata parse error in add_user_phone HOT 4
- Automatic proxy configuration HOT 2
- get_authentication_log clearing out Params HOT 3
- Add Get User by Email HOT 1
- 400 Bad Request response when trying to add a token for a yubikey HOT 1
- Duo client installed via pip is missing the get_users_by_names func HOT 3
- Getting "Received 429 Too Many Requests" for auth logs even if hitting the API in 6-7 minute intervals
- Getting 40103 on making GET REST API calls HOT 5
- Tests are failing because actual requests are being made HOT 1
- How to use duo_client_python to access an integrations secret key? HOT 2
- next_offset pagination in auth logs HOT 12
- add get auth summary endpoint to the admin object HOT 1
- bad link in READ.me
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from duo_client_python.