Comments (2)
shaundon
commented on May 19, 2024
Hey – I'm not 100% on this, I think there may be use cases where it's appropriate to use a string, so it may be best to leave it as is.
from duffel-api-javascript.
igorp1
commented on May 19, 2024
Hey @nathanlindsay! I'll be closing this for now since there hasn't been any activity, but please feel free to re-open if you have any other question. To clarify, we do seem to reuse the OfferRequestSlice type on the CreateOfferRequest type. CreateOfferRequest is used for the payload, where your input and destination are strings with the iata code.That's why we have origin and destination as either Place or string
from duffel-api-javascript.
Related Issues (20)
- Suggestion: Get flight fare rules using fare basis code HOT 2
- Rate Limiting HOT 4
- Create Duffel App HOT 1
- `max_connections` is missing from type `CreateOfferRequest` HOT 1
- `OfferPassenger`` type` should be `DuffelPassengerType` not `string` HOT 1
- Missing key in OfferSliceSegment type HOT 2
- return_offers question HOT 2
- Undefined booking response, no errors returned HOT 18
- Selected service ID is not the valid one when reaching orders.create() HOT 3
- Reporting a vulnerability HOT 1
- Typescript Types are not aligned with API docs HOT 2
- Version 2.5.2 : Cannot find module 'Client' or its corresponding type declarations HOT 3
- Version 2.5.3: Cannot find module 'types' or its corresponding type declarations. HOT 4
- Type mismatch between documentation and Typescript types HOT 2
- import{URL as s,URLSearchParams as e}from"url" HOT 3
- Issue getting x-request-id
- `Airline` interface is missing `conditions_of_carriage_url` field HOT 1
- Missing `PassengerTitle` enum values HOT 1
- Question: What is the reason for different `origin`/`destination` types on `OfferSlice`/`OrderSlice` `Segment`s? HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from duffel-api-javascript.