Comments (11)
Resolved in #35 :)
from ios-search-and-stories.
@nilnilnil I'll be able to fix this when I'm back in tomorrow.
from ios-search-and-stories.
from ios-search-and-stories.
Please use this new icon asset globally...
from ios-search-and-stories.
Got it, thanks! A new build (v5.2) has been created and submitted to Apple that includes this icon as well as @micpringle's changes to improve the updating of story feeds.
from ios-search-and-stories.
Sorry to chime in late on this comment but the header is meant to be semi-transparent. @micpringle had mentioned that it was but looking closely I see that it's not. Any particular reasoning behind this?
from ios-search-and-stories.
If I remember correctly Mic mentioned that it was using the default system navigation bar which is supposed to provide the blur over the content that scrolls behind it. Checking the code, we use a UINavigationBar but I think we'd need to use a full UINavigationController in order to get the blur. That may be tricky to add without rewriting a ton of the navigation code that we were handling manually. It'd be simple to make the nav bar translucent, but I'll check with Mic in the morning to see about getting the full blurred nav bar.
from ios-search-and-stories.
Sounds good. I'd opt for full opacity if we can't get the blurred effect.
from ios-search-and-stories.
I've taken a look at blurring the navigation bar. Here's what I've found:
- The current view hierarchy isn't a standard setup (i.e. it's not using
UINavigationController
) which means we'd need to update each different view controller manually and independently. - Part of the current setup limits the size of the content to the size of the screen minus the height of the status bar and navigation bar. We can obviously change this to match how iOS 7 layouts should work, but...
- Because of the unusual setup, the content would then appear behind the navigation bar. In order to fix this we would need to manipulate the
contentInset
. The only thing with this is that the PTR control already manipulates thecontentInset
internally, so we'd need to take this into account and may even have to change how that control works internally. - Finally, even if we fix all of the above, the PTR control would sit directly underneath the navigation bar when the stories view in not scrolled by the user; this means by default the navigation bar on the stories view would have a reddish tint.
It's totally your call, as we're happy to go ahead and try and resolve all these issues, I just wanted to bring them to your attention first. The other option would be to simply put it on the back-burner until we begin looking at the from-the-ground-up rewrite, if that's still on the cards.
/cc @nilnilnil
from ios-search-and-stories.
I don't think it's worth it until we revisit our mobile strategy. Please hold on this.
from ios-search-and-stories.
@nilnilnil No problem.
Closing then since @sreilly fixed the original iPad icon issue.
from ios-search-and-stories.
Related Issues (20)
- When refreshing a readability story the page turns red HOT 2
- Address link does not open native maps app HOT 9
- Search-field issue HOT 2
- Crashes on older iPhones running older versions of iOS HOT 15
- Mosaic view completely broken in the new build (6.0.1) HOT 4
- Viewport height issue HOT 7
- Grey border on app icon HOT 6
- Feature request: Add support for multiple tabs HOT 1
- Feature request: Option to switch to dark mode in low light HOT 1
- 'Added' and 'Removed' pop up missing when favoriting a story from the main story feed HOT 1
- Project references files that are ignored by the VCS HOT 6
- Navigation buttons disappear after view video HOT 1
- DuckDuckGo jumps to far back after swiping backwards HOT 1
- Support Universal Links HOT 8
- App crashes when the send feedback button inside the settings view is clicked HOT 7
- Clearing cookies/cache doesn't clear local storage - privacy risk HOT 5
- Feature Request: Support URL Schemes HOT 3
- App crashes on startup (iOS 7.1.2) HOT 4
- Red screen after searching or tapping a story HOT 2
- Add voice search to app
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ios-search-and-stories.