Coder Social home page Coder Social logo

Comments (5)

t-young31 avatar t-young31 commented on May 29, 2024

You are completely correct โ€“ย I've been meaning to fix this, so now maybe the time! Expect to see this in v1.3.0 ๐Ÿ˜„


tsguess.solvent = get_solvent(molecule.solvent, kind='implicit')
molecule = TransitionState(tsguess)

This doesn't work because the solvent gets inherited from the optional 'reactant' argument to TransitionState rather than the ts_guess, which I very much agree is confusing and bad!

from autode.

t-young31 avatar t-young31 commented on May 29, 2024

Hi @ffmulks โ€“ย this has been fixed in #167. If you have time I'd very much appreciate if you could try it out and see if the behaviour matches what you'd expect โ€“ย thanks ๐Ÿ˜„


working example:

from autode import Atom
from autode.transition_states import TransitionState, TSguess


ts_guess = TSguess(mult=2, solvent_name='water',
                   atoms=[Atom("H", 4.52368, -0.00030,   0.00065),
                          Atom("H", 5.47129,  0.00009,  -0.00023),
                          Atom("H", 6.41149,  0.00045,  -0.00109)])

ts = TransitionState(ts_guess)
assert ts.solvent is not None

ts.optimise()

from autode.

t-young31 avatar t-young31 commented on May 29, 2024

see if the behaviour matches what you'd expect

I'm going to hope it has because i'm going to merge #167 now to try and get a release out shortly

from autode.

ffmulks avatar ffmulks commented on May 29, 2024

Weird, that works for me whereas my script in SLURM failed to do the very same thing. I suppose I may just have an environment mixup somewhere.

from autode.

t-young31 avatar t-young31 commented on May 29, 2024

๐Ÿ‘ป

from autode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.