Comments (4)
You hit the nail on the head. This code dates back many years (before we had rest params in JS). This particular bit is not from J5, but I see we have some instances in J5 as well so I'll get those tracked down in both repos.
Thanks for pointing it out and thank you for spending time on this. I appreciate it very much.
from j5e.
Happy to help. I'm learning a lot along the way. ;)
If I run into other code that appears historic, I'll make a note and pass them along.
from j5e.
Shouldn't have closed this. I have yet to make this change and I will forget if I don't leave it open.
from j5e.
This is done in J5e. The instances I was remembering from Johnny-Five have either already been replaced, or weren't suitable for this refactor.
from j5e.
Related Issues (20)
- Automate docs build with GH actions HOT 1
- Automate npm publishing when a release is tagged
- Animation target is being lost on next()
- Needs a linter
- Finish button tests
- Add debounce option to button
- Should j5e include an http client/server module(s)? HOT 1
- fmap function - really Float32? HOT 4
- Should LED default to PWM HOT 2
- sensor manifest appears to use within inconsistently HOT 1
- Use of Object.defineProperties instead of getters? HOT 3
- Test Thermistors with Actual Hardware
- Add tests for sink drive LEDs
- What is Host.io? HOT 3
- Arrow function causes stack dump HOT 7
- Peripherals should have a close method per ECMA 419
- Sensors should have a sample method per ECMA 419
- Thermometers should have a Temperature property per ECMA-419
- Website is down HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from j5e.