Coder Social home page Coder Social logo

Increase allowed line length about stone-soup HOT 5 CLOSED

dstl avatar dstl commented on August 28, 2024
Increase allowed line length

from stone-soup.

Comments (5)

sdhiscocks avatar sdhiscocks commented on August 28, 2024

So even with screen real estate being larger, very long lines can be unreadable and can get messy are allows people to nest in more if block, for loops, etc. It also can become more difficult for side by side comparison, especially for 3-way merges (but these are rare to be fair).

We have a lot of equations and long variables names (which makes code more readable) that could really do with some more room, as they are becoming less readable by the time your forced to break them up over multiple lines. We also typically have the bulk of code in class methods, so lose 8 characters before you even get started.

There's always a balance to be had, but I think increasing to 99 characters would improve readability.

If we did make a change, I'd suggest we don't make one massive code change but allow the project to transition naturally as we make code changes.

from stone-soup.

jmbarr avatar jmbarr commented on August 28, 2024

😐

from stone-soup.

DaveKirkland avatar DaveKirkland commented on August 28, 2024

I don't really have a problem with this. Can a local flake8 configuration file be distributed with the project, so that it passes the flake8 testing? Or include instructions for how to manually configure this ourselves,

from stone-soup.

etfrogers-dstl avatar etfrogers-dstl commented on August 28, 2024

@DaveKirkland Yes, the flake8 configuration can be committed, if that what is wanted. I assume CircleCI would honour it (otherwise, we might have to configure that separately).

from stone-soup.

rjgreen-dstl avatar rjgreen-dstl commented on August 28, 2024

closed as addressed in #166

from stone-soup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.