Flickering when using other plugins about nvim-scrollview

[dstein64]

This is now fixed (PR #8). Thanks for reporting this @mroavi and @timtyrrell! Please let me know if you encounter any issues after updating.

[timtyrrell]

I noticed this with my fzf pop-up, also. It goes away when disabling this plugin

[dstein64]

Thanks for reporting this @mroavi!

Is just the scrollbar flickering, or are other elements on the screen flickering? Does the flickering occur just when scrolling or for other movements as well (e.g., changing windows)?

Are you using a version of nvim-scrollview newer than 0ed558e, which addressed a flickering issue when scrolling.

I tried to reproduce the issue by running just nvim-scrollview and goyo, but I was unable to encounter the issue. Did you have any other plugins loaded at the time?

[mroavi]

The nvim-scrollview version I currently have is: e294972
And this is my nvim version:

NVIM v0.5.0-ef3230f
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3
Compilation: /usr/bin/cc -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -O2 -g -Og -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wmissing-prototypes -Wvla -fstack-protector-strong -fno-common -fdiagnostics-color=always -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -DMIN_LOG_LEVEL=3 -I/home/runner/work/neovim/neovim/build/config -I/home/runner/work/neovim/neovim/src -I/home/runner/work/neovim/neovim/.deps/usr/include -I/usr/include -I/home/runner/work/neovim/neovim/build/src/nvim/auto -I/home/runner/work/neovim/neovim/build/include
Compiled by runner@fv-az36-166

I did not have any other plugin loaded. I started nvim like this: nvim -u minimal.vim where minimal.vim contains the code posted above.

I am running Manjaro:

❯ lsb_release -a
LSB Version:    n/a
Distributor ID: ManjaroLinux
Description:    Manjaro Linux
Release:        20.2
Codename:       Nibia

Here is an example of the flickering I'm seeing:

I do not see that issue if nvim-scrollview is not loaded.

Awesome plugin by the way! I'm keeping with or without this issue.

Edit: I also see artifacts even when creating a new window, e.g. with :vnew or :new.

[dstein64]

I am able to reproduce the flickering.

I guess this might interact similarly with other plugins besides the two you've mentioned.

You might be interested in the following band-aid that can prevent the flickering.

nnoremap <Leader>go :ScrollViewDisable<CR>:Goyo<CR>:ScrollViewEnable<CR>

I'll try to work on a more robust solution for nvim-scrollview, to avoid this type of behavior.

[dstein64]

The call to redraw was causing the issue. Coincidentally, that call was added to prevent scrollbar flickering. I was able to work around both issues (window flickering and scrollbar flickering) by removing redraw and ensuring that existing scrollbars are removed after the new scrollbars are added.

[timtyrrell]

@dstein64 seems to be fixed now, thanks!