Comments (4)
The spacing issue is addressed as of PR #130. When scrollview_always_show
is used and a sign for gitsigns
would correspond to multiple rows of the scrollview column, all those rows will be used.
@sho-87, can you provide steps for reproducing the other issue? Something like:
$ git clone <REPO>
$ git checkout <COMMIT>
$ nvim
# plus a list of edits to the file to reproduce the issue
from nvim-scrollview.
awesome! thanks for your speed
from nvim-scrollview.
to reproduce, here is a fresh config that bootstraps lazy and grabs scrollview and gitsigns at specific commits:
init.lua:
local lazypath = vim.fn.stdpath 'data' .. '/lazy/lazy.nvim'
if not vim.loop.fs_stat(lazypath) then
local lazyrepo = 'https://github.com/folke/lazy.nvim.git'
vim.fn.system { 'git', 'clone', '--filter=blob:none', '--branch=stable', lazyrepo, lazypath }
end ---@diagnostic disable-next-line: undefined-field
vim.opt.rtp:prepend(lazypath)
require('lazy').setup({
{
"lewis6991/gitsigns.nvim",
commit = "078041e",
config = function(_, opt)
require('gitsigns').setup {
signcolumn = true,
}
end
},
{
"dstein64/nvim-scrollview",
commit = "1d80f72",
config = function(_, opts)
require("scrollview").setup(opts)
require("scrollview.contrib.gitsigns").setup(opts)
end,
opts = {
always_show = true,
column=40,
}
},
})
git init
in a directory, create a new file, and commit it. I just used some random text like:
jkh
jklsdfh
sdf
sdf
sdf
sdf
sdf
sdf
sdf
sdfdsf
asdasdasd
isdfsdf
- nvim using the config above
- add a new line to the end of the file and you'll see this, which is the correct colour for an addition:
- go to the line above and change it, and this is where it goes wrong:
the marker is still there for the line addition, but the colour that used to be the correct blue has now turned into purple
from nvim-scrollview.
The second issue is fixed in 5a7eb7e. A gitsigns
change hunk could be comprised of a change and an addition. The existing code was assuming it was only a change, with no addition.
@sho-87, thanks for reporting the issue and providing the detailed reproduction steps. If you're still encountering a problem, please let me know with a new Issue or a comment here.
from nvim-scrollview.
Related Issues (20)
- [question] disabling keybinds HOT 19
- Error related to Mappings. HOT 3
- Refresh mappings conflict with buffer-local mappings HOT 2
- Bug: E5108: Error executing lua [string ":lua"]:1: attempt to call field 'set_state' (a nil value) HOT 3
- Bug: Scrollview signs+null-ls causes nvim crash on ":set nu" or ":%s" replace HOT 1
- Issues with Winblend and Transparent Terminal Background HOT 6
- Feature Request: set some sign inside the scrollbars HOT 9
- `winblend` is not respected on hovering signs HOT 2
- Changing `list/nolist` or `listchars` crashes nvim with `trail` sign enabled at startup config HOT 3
- Add support for gitsigns HOT 4
- Pointer position is not adjusted when `winbar` is set HOT 1
- Signs won't go away HOT 4
- Search sign colors HOT 3
- opening a large file with a lot of error slows down nvim HOT 4
- [Question] How to add a horizontal scrollbar ? HOT 2
- nvim-scrollview not seeing diagnostics from coc.nvim HOT 2
- Compatibility with 0.10 extmark sign HOT 2
- Cursor positions changes undeterminably while scrolling past it HOT 4
- Cursor moves to bottom left of window when dragging scrollbar with wrapped lines
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nvim-scrollview.