progress test fail about dax

[dsherret]

Yeah, that's what I meant by "I see some async code that's not being awaited". It should have been awaited and forgot to because we don't have floating promise detection in deno lint (kind of annoying and wish we had it). I updated the code now so this issue and those unawaited promises should be fixed.

(I'm going to do a release later tonight probably)

[dsherret]

What version of Deno are you running the tests with?

[sigmaSd]

linux
deno 1.29.1+7ce2b58 (canary, x86_64-unknown-linux-gnu)
v8 10.9.194.5
typescript 4.9.4

[dsherret]

Also, what's the full call stack at src/console/utils.ts#L166?

[sigmaSd]

I added log(new Error().stack!;) there

Error
    at getStaticText (file:///home/mrcool/dev/deno/others/dax/src/console/utils.ts:166:17)
    at refresh (file:///home/mrcool/dev/deno/others/dax/src/console/logger.ts:19:28)
    at Object.setItems (file:///home/mrcool/dev/deno/others/dax/src/console/logger.ts:15:10)
    at forceRender (file:///home/mrcool/dev/deno/others/dax/src/console/progress/interval.ts:52:10)
    at ProgressBar.forceRender (file:///home/mrcool/dev/deno/others/dax/src/console/progress/mod.ts:132:5)
    at file:///home/mrcool/dev/deno/others/dax/mod.test.ts:885:6
    at testStepSanitizer (deno:cli/js/40_testing.js:448:13)
    at asyncOpSanitizer (deno:cli/js/40_testing.js:147:15)
    at resourceSanitizer (deno:cli/js/40_testing.js:374:13)
    at Object.exitSanitizer [as fn] (deno:cli/js/40_testing.js:431:15)

[dsherret]

Ok thanks! I see some async code that's not being awaited. I will look into it.

[dsherret]

That makes no sense it ends up there because forceRender will exit if !isInteractiveConsole. Maybe the debugger makes stdin a tty somehow so that changes the behaviour. How are you running the tests?

[dsherret]

Oh, maybe I need to check that stderr is a tty as well. That will probably fix it. I'll open a PR

[sigmaSd]

I tested it and that fixes it

[sigmaSd]

just one more javascript question, so this doesn't need to be awaited

dax/src/console/progress/interval.ts

Line 52 in 043be64

logger.setItems(LoggerRefreshItemKind.ProgressBars, items, size);

? even if it internally returns an async function (refresh)

dax/src/console/logger.ts

Line 18 in 043be64

async function refresh(size?: ConsoleSize) {

[sigmaSd]

I see, thanks for fixing it so quickly!

because we don't have floating promise detection in deno lint

definitely would be a nice upgrade