not recognized by heroku about modernwebdevgenerator

[dsebastien]

I don't have any experience with Heroku so I don't know how to help you out.
One question: what happens if you copy the dist folder contents to a bare bones Web server (e.g., Apache or Nginx) or start a Web server using http-server, superstatic or a similar solution? Does the application work? If so, then it's really something about Heroku..

[gilbertlucas46]

i tried just pushing a subtree to heroku using this commang "git subtree push --prefix dist heroku master"
but its failing because heroku cant recognized what kind of build this is.

While in apache I'm receiving a Get error

[dsebastien]

Well the thing is that the build shouldn't matter to Heroku. The dist folder contains a fully static site; maybe this article could help you out: https://gist.github.com/wh1tney/2ad13aa5fbdd83f6a489

As for the bundle.min.js loading error, without more information I really can't help.

[gilbertlucas46]

Hi, I followed the instructions from the link you just gave me it works!, i can see the site.
what I did is I point index.php to /dist folder
but now the problem is it doesn't seem to find the assets (css,js)

Here's the link of my application from heroku for your reference
https://cheapytrippy-test.herokuapp.com/

without ../

[dsebastien]

Good news :)
For the bundles loading, the only thing that comes to my mind is that you might be using an older version of the generator/build and/or have generated your project before my most recent changes.

There were some issues that I did fix: #94 & dsebastien/modernWebDevBuild#105. I guess these might be related (?).

[gilbertlucas46]

wow nice ill check it today, then I'll let you know. thanks for help!

By the way I've been using this repo because I needed angular with it
https://github.com/dsebastien/modernWebDevGenerator
and i look at the package.json and theres no gulp-wait included

can i just add this inside gulp/task?
https://github.com/dsebastien/modernWebDevBuild/blob/master/src/gulp/tasks/serve-dist.js#L51
serve-dist.js

[gilbertlucas46]

Hi so i figured out whats going wrong, turns out i need to add dist/ in every path of my assets.

<script src="dist/bundle.min.js"></script>

here's the new heroku app I made
https://cheapytrippy.herokuapp.com/

[dsebastien]

Meaning that your index.html page is not within the dist folder?
If so then it's normal that it didn't work. The idea of the dist folder is that it contains a self-contained (sic) version of the app.

[gilbertlucas46]

Nope it is inside the dist folder
On May 6, 2016 4:19 PM, "Sebastien Dubois" [email protected] wrote:

Meaning that your index.html page is not within the dist folder?
If so then it's normal that it didn't work. The idea of the dist folder is
that it contains a self-contained (sic) version of the app.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#102 (comment)