Coder Social home page Coder Social logo

Comments (5)

ds300 avatar ds300 commented on September 23, 2024

Thanks for the suggestion. I had no idea windows support would be so easy to provide!

How about + instead of space? Or could you provide some other alternative characters? Something about the idea of putting spaces in filenames scares me at a deep instinctual level, although I couldn't say why so maybe it's an irrational fear :-)

from patch-package.

keeganstreet avatar keeganstreet commented on September 23, 2024

+ would work just as well. It is not valid for npm package names, but it is valid in filenames.

Would you like me to make a PR for this? I would suggest that new patches are named with a plus instead of a colon, but findPatchFiles looks for patches with both the current and new naming conventions so the change is backwards compatible.

from patch-package.

ds300 avatar ds300 commented on September 23, 2024

Yeah backwards compatibility is a must. I'll do this later tonight unless you submit a PR first. Should be a tiny change.

from patch-package.

ds300 avatar ds300 commented on September 23, 2024

image

from patch-package.

keeganstreet avatar keeganstreet commented on September 23, 2024

Thanks @ds300 !

from patch-package.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.