Coder Social home page Coder Social logo

Improve yarn compatibility about patch-package HOT 2 CLOSED

ds300 avatar ds300 commented on September 23, 2024
Improve yarn compatibility

from patch-package.

Comments (2)

ds300 avatar ds300 commented on September 23, 2024

I could run patch-package on it's own postinstall hook. That comes with a couple of trade offs

  • You'd no longer get to see patch-package's stdout, because yarn doesn't print any output for postinstall hooks of dependencies unless they fail. And even then the output is not colorized 😢
  • With npm you'd still need the prepare hook, since patch-package's postinstall hook wouldn't be run when updating a patched package. This means patch-package would get executed twice on an initial install, which is not a big deal since it is supposed to be idempotent.
  • patch-package could be used by libraries, which is a terrible idea unless it gets installed as a nested dependency of that library when that library itself is installed by some other library or app. I doubt there's a way to ensure that.

from patch-package.

ds300 avatar ds300 commented on September 23, 2024

fixed in 5.0.0

from patch-package.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.