Failed to apply patch for package xxx on Windows about patch-package

[ds300]

This should be fixed now, in v3.4.1 - Thanks for your patience. Please feel free to reoopen the issue if you find it is still affecting you.

[manuhook]

Thanks again,

In git bash :

patch -p1 -i patches/react-native-navigation+1.1.213.patch --verbose

yarn patch-package react-native-navigation

I have the same error in the msdos prompt.

Thanks !

[manuhook]

PS: Everything is working well on OSX

[ds300]

Hi! :)

Windows support is still a little shaky. Do you have the git core.autocrlf property set to true?

Try running

git config --global core.autocrlf true

And then check out the repo again, then let me know if it works this time.

[manuhook]

Thanks ds300 :)

Unfortunately no luck with core.autocrlf set to true

[ds300]

In that case, can you try running the following in git bash:

patch -p1 -i patches/react-native-navigation+1.1.213.patch --verbose

and if that doesn't report any errors, then run

yarn patch-package react-native-navigation

This should create a new version of the patch file. You should test it by removing node modules and running yarn again. If the patch is applied successfully, it means it's somehow different to the previous version. Let me know how!

[ds300]

Hmm 🤔 that seems to be a problem with yarn not invoking commands on windows properly. Looks like you're using an old version of yarn. Maybe you could upgrade yarn and try again?

[manuhook]

Better with a yarn update :)

Now the patch created by the last command is identical to the one i was having before ^^;

[ds300]

so after creating that new patch, yarn patch-package still fails?

[manuhook]

yes same error as my first message

[ds300]

Any chance you could zip up the patch file and share it with me?

[manuhook]

Sure,
I've zip up 3 patches, same problem for each one of them

patches.zip

Thanks again,

[ds300]

Thanks for the patch files! I've figured out what's causing this issue, and it goes away if I re-write the patch files to get rid of CRLFs before applying them, regardless of whether the source files they're patching have CRLFs or just LFs.

I'll push out a fix tonight. Thanks again for your issue report and the continued collaboration 💯