Comments (11)
from patch-package.
Instead of working around host platform's peculiarities, would it make sense to replace git with a js implementation of diff-patch?
from patch-package.
Maybe. I looked into it a couple of weeks ago when fixing some windows support issue. It seemed like overkill for that but in the long run might be worth it. But then again it would need a lot more code to be written and tested, whereas fixing forward/back slash usage is not much code, just a bit fiddly.
from patch-package.
Oh, and thanks for the report, I'm looking into it now :)
from patch-package.
That's awesome! Really clean implementation. Using hashes is a cool idea. patch-package does dry runs to detect whether the patch was already applied, which is likely a bit more expensive.
from patch-package.
from patch-package.
Is it that the underlying patch
implementation can tell that the patch was already applied?
Kinda. If the dry run fails, then it does a "reverse" patch dry run, which is like assuming the patch was already applied and trying to unapply the patch. If that "reverse" patch is successful, then it means the patch was already applied. This is more complicated and slower than hashing, but also allows the contents of the file to change in independent unaffected areas, e.g. if the package is updated but the patch is still needed.
from patch-package.
from patch-package.
Apologies for the delay. I had a chance to look into this today. Couldn't reproduce the issue on Windows Server 2016 with latest Cygwin, but have tried enforcing use of unix-style paths everywhere and it seems to be OK. Will test some more tomorrow and publish a new version if all goes well.
from patch-package.
Testing went well. v3.4.6 might fix this. Let me know if you try it out.
from patch-package.
Haven't been able to reproduce this issue, and have changed all paths to be unix-style, so I'm closing this due to inactivity. Feel free to reopen it if you find you're still encountering the issue.
from patch-package.
Related Issues (20)
- Failed to apply patch for package react-native-agora HOT 1
- Is there a way to convert pnpm patches to patch-package patches? Or do they use the same format? HOT 2
- -
- Uniterpretable Error during makePatch HOT 10
- react-native-otp-verify+1.1.6.patch
- Confusing syntax error message when pointing to a package that does not exist
- Patch not applied after package upgrade
- inflight - Missing Release of Resource after Effective Lifetime HOT 1
- how get the post-install to run when installing cosmos (or storybook and the like)
- Patch cannot be applied when it simultaneously renames and modifies the file HOT 2
- npx patch-package [email protected] error HOT 1
- Not sure if I'm clear on how to re-apply updated patch...
- Can patch-package detect content changes in package.json? Let's say I changed a dependency version? HOT 3
- Failed to apply patch for package react-native at path node_modules/react-native HOT 1
- Failed to apply patch for package react-native-ui-lib at path node_modules/react-native-ui-lib
- Installing a dependency with its own local patches doesn't apply them HOT 1
- Support for yarn berry HOT 1
- ERROR with RN 0.74.x HOT 1
- Respect `copy from`/`copy to` extended headers
- How to exclude android\build folder?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from patch-package.