Color function maker about testssl.sh

[szepeviktor]

Maybe the b/w function variables shouldn't have a COLOR_ prefix.

[szepeviktor]

Please consider including it.

[drwetter]

I removed the stars also from my code (ugly) that needs to be removed as well.
Then could you give me an example how that function would be called? I am
not quite sure about it.

Am 11/17/2014 09:57 PM, schrieb Viktor Szépe:

Please consider including it.

—
Reply to this email directly or view it on GitHub #27 (comment).

[szepeviktor]

colorfuncmaker() generates functions like litegreen or green. So no modifications needed.
Look at the eval lines!

[drwetter]

@szepeviktor : Sorry for keeping this open for so long.

Would you mind doing a PR?

[szepeviktor]

I am sorry. I'd like to contribute only one function.
The one above generates all these function: https://github.com/drwetter/testssl.sh/blob/master/testssl.sh#L256-L348
So your code gets shorter.

[szepeviktor]

generates all these function

Should I explain what this means?

[drwetter]

Ok, no problem.

Like the idea though, so I reopened it for others to volunteer.

[szepeviktor]

The PR is easy. You just delete the literally defined functions (for example pr_liteblueln) and put this one in your code.

[szepeviktor]

You should also declare an array with all the colors.
declare -A COLORS=( [litegreen]='0\033[0;32m' [green]='2\033[0;32m' ) etc.

[szepeviktor]

removed the stars also from my code

So start should also be removed from this function.

[drwetter]

Am 07/23/2015 um 01:50 PM schrieb Viktor Szépe:

generates all these function

Should I explain what this means?

I got it, not sure whether the generated functions are kind of global then.
I assume they are, otherwise you wouldn't have suggested it.

[szepeviktor]

If they are not global, just make this function simply inline code.

[drwetter]

Thx!

[drwetter]

Needed to revert this.

Catch was the functions are being initiated at a fixed time instead of while calling.

Other solution needs to be found for this color_maker

[szepeviktor]

OK