Coder Social home page Coder Social logo

Comments (2)

joshafeinberg avatar joshafeinberg commented on July 22, 2024 1

Unfortunately we don't have the ability to support working on each CI. If you need to use ForkCommit you need to work with your CI to make sure all branches are pulled that are required. You can see in this file (https://github.com/dropbox/AffectedModuleDetector/blob/e4e80174988ca64ef7cf2b840a34801de0aade94/affectedmoduledetector/src/main/kotlin/com/dropbox/affectedmoduledetector/commitshaproviders/ForkCommit.kt) how we detect the parent branch and you just need to ensure your CI can pull it

Please let us know if you find any issues with the ForkCommit process but I will be closing this as like I stated, we do not have the bandwidth to support all our users CI platforms

from affectedmoduledetector.

Evleaps avatar Evleaps commented on July 22, 2024

I investigated this problem.
As I use specifiedBranch = "origin/dev" and compareFrom = "SpecifiedBranchCommit" my branch on ci always comparing with latest version "origin/dev". I using fetch dev on my CI for solve this problem.

Hence, when we push a new commit the CI compares your commit with updated develop, but other developers in your team already changed the develop branch and you can see more affected modules than you really affected.
Time is important. The count of the developers is important.

How to fix it?
You can call git merge origin dev:dev before running the pipeline. It will be working and after this, u will see only your affected modules in affected_module_detector.log. But this way might be is not cool:

  • Because u will get some problems with epic branches.
  • Also, u will get an extra merge commit every time when u push a new commit.

Hence, I suppose that might be better to use another compareFrom variant like ForkCommit. It works perfectly on a local machine, but I got an error on my CI.

* What went wrong:
Could not evaluate onlyIf predicate for task ':cargo:common:testReleaseUnitTest'.
> Parent branch not found

@joshafeinberg, can you or your colleagues help with the wrong. How can I use ForkCommit on my CI?

from affectedmoduledetector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.