Feature request: Need support for includeBuild about affectedmoduledetector

[joshafeinberg]

Alright, then I will close this but feel free to put up a PR for you includeBuild support if you are interested

And thank you for the note on how to better handle dependencies

[digitalbuddha]

Sounds interesting, How would we get the git data for the external build? We would need it to find which files are changed.

[rougsig]

Sample https://github.com/rougsig/AffectedModuleDetector/tree/main/sample

I've add failing test to includeBuild to that file sample/include-util/common/src/test/java/com/dropbox/detector/sample_util/ExampleUnitTest.kt. Run task for check. Task was green.

logs

[INFO] [amd] unknownFiles: [sample/build.gradle, sample/include-util/common/src/test/java/com/dropbox/detector/sample_util/ExampleUnitTest.kt], changedProjects: [], buildAll: false

In gradle dependencies to module in includeBuild realised like external dependency.
Like that: implementation "com.example.includeutil:common".

More info can be found here.

---

Expected behaviour is:

Project structure is:
app -> utils-module (in includeBuild)

Change in utils-module (in includeBuild).
Test will be executed for: app and utils-module (in includeBuild)

[rougsig]

To find module from include build, we need to know group of that module.

I can try to make PR with that logic, but it have one problem. We need to register group id and path of include build.

[joshafeinberg]

Sorry for the delay here but can you explain what you mean by "We need to register group id and path of include build" @rougsig? Are you saying that we would need to have them manually state any included builds?

I've played around with this a bit and it seems like the only way to get what included builds programmatically is to do gradle.includedBuilds but then we still don't get information of what dependencies those are replacing. I'm just not sure if this is feasible with the current gradle system

[rougsig]

I've implemented my own version of affected-module-detector with includeBuild support. Actually affected-module-detecktor should resolve dependencies, not iterate by them as now.