AWS keys with special characters break the upload and create a misleading error about drone-s3

[bradrydzewski]

marking as help wanted. If someone is able to identify the root cause (drone issue vs s3 cli issue, etc) and issue a pull request I'll be happy to review and merge

[thyming]

Seems to be because of this: aws/aws-cli#602
They've closed the issue but people are reporting the same thing that I experienced, namely that a plus sign blows things up.

[thyming]

FWIW I just regenerated keys until I got one without special characters :(((

[thyming]

If I get a chance this week I'll make a PR that uses the aws sdk instead of the cli.

[bradrydzewski]

@thyming thanks that would be great! A community member has also been migrating the s3-sync plugin to use the native Go sdk. You can see this branch for reference https://github.com/drone-plugins/drone-s3-sync/tree/native

[thyming]

In the use case of drone exporting an artifact, it seems like drone-s3-sync and this module can be collapsed into one. This module with the recursive option does the same thing as sync, no?

[bradrydzewski]

closing since we've updated to use the native Go client. Not sure yet if we'll merge s3 and s3 sync into a single repository, but this should be solved in 0.5 version of drone