Comments (8)
BAM! Works great. Many thanks.
from react-rating.
Hi @Tawpie!
I think I see what you mean... So I assume that the rating pseudo-hovering on touch devices should be disabled in this case, right? Or you want both behaviors to coexist (hovering and scrolling)? For the former situation I think we could find an easy solution in combination with the quiet
mode. For the latter, well, not sure yet π
from react-rating.
If disabling hovering does the trick that's outstanding! I wouldn't have thought of combining it with quiet
mode thoughβperhaps the prop's "whether to animate hovering" description could be updated. If quiet mode is the cleanest I'm all for that.
from react-rating.
Release v2.0.6 should solve this issue, or at least, provide a reasonable alternative.
My first idea was to just ignore hovering on touch devices. However there already was an example on hovering over a quiet rating. It make sense to me but I don't want to break anything. I don't know if someone is relying on this behavior π
. So, after some thought, I just decided to try to differentiate between click
and swipe
on touch devices. I kind of removed the swipe
selection on quiet
mode while keeping it on normal mode without removing the onHover
event on both (as it is working now).
Hope it is enough or at least it does the trick for you. Let me know otherwise and we can try to find another way.
from react-rating.
Thank you! I'll give it a whirl. Just verifying, I need to have the component in quiet
mode?
from react-rating.
Exactly π
The quiet
mode should avoid triggering the click event on a swipe gesture.
from react-rating.
v2.0.6, with component's quiet
prop set to {true}
prevents selection of a rating when the user moves the touch point. Verified on iOS 13.5.1 (iPhone 6S+) and Android 10 system update 2020-05-01 (pixel 1).
from react-rating.
Related Issues (20)
- Initial Rating returns null only renders once
- on version 2.0.1 ReactRating-component onChange-event seems to return always value of initialRating HOT 15
- Error during installation on jenkins HOT 2
- emptySymbol is not hidden when fullSymbol is displayed HOT 9
- Cannot read property 'type' of undefined
- Method comments are switched HOT 1
- Misalignment HOT 4
- Sorry HOT 1
- Warning: Using UNSAFE_componentWillReceiveProps in strict mode is HOT 10
- Warning: Using UNSAFE_componentWillReceiveProps in strict mode is not recommended and may indicate bugs in your code. See https://reactjs.org/link/unsafe-component-lifecycles for details. HOT 5
- Feature request: Lighter DOM Size HOT 1
- Doesn't work with react 17 HOT 1
- Selection requires double click if onClick method provided HOT 3
- How to add the validation for the rating component HOT 1
- Add option to remove default style
- mixed symbol but react component HOT 1
- Package should be marked as deprecated and a replacement fork nominated HOT 2
- React 18: TS2786: 'Rating' cannot be used as a JSX component. HOT 9
- `@types` dependencies should be in `devDependencies`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-rating.