Comments (9)
IIRC, anything that calls lockFocus
to a view don't work on Mojave. I had something similar happen on my NetHack3D branch, and I think DrawKit uses lockFocus
.
from drawkit.
My guess is the targeting of the Mojave SDK. 9.4.1 targets the High Sierra SDKs, and Mac OS X does some trickery to make sure apps built against older SDKs still work somewhat.
from drawkit.
Looking through the code, I found one method that calls -[NSView lockFocus]
is in DKLayerGuide… if DK_DRAW_GUIDES_IN_CLIP_VIEW
is set. Other than that, DKDrawingView
does override -lockFocusIfCanDraw
, and the comment suggests that the code could go into -viewWillDraw
. In fact, it wouldn't surprise me if apps/frameworks linking against Mojave aren't calling -lockFocusIfCanDraw
and thus the needed functions aren't getting called.
from drawkit.
any work around you'd suggest @MaddTheSane ? I'm used to looking at DrawKit internals, but I haven't tried modifying it at all. Is that the route that's going to have to happen for mojave support?
from drawkit.
Ok, the following works:
- swift 4.1.2
- xcode 9.4.1
- Mojave
any thoughts on what Xcode or swift 4.2 are doing to jack it up?
from drawkit.
@MaddTheSane if you haven't had the chance to test it on xcode10 / mojave / swift 4.2 yet, I'll get to it this evening.
from drawkit.
@MaddTheSane been a while since I worked on the project that used this -- did the change you implemented with ff220d6 means it should work with Xcode 10 now?
from drawkit.
It should.
from drawkit.
confirm it works - we should tag a new release @MaddTheSane @grahammiln - 1.0.4?
from drawkit.
Related Issues (20)
- Load styles from file HOT 1
- Intent to move to new licence (MPLv2)
- scrollWheel jerky zoom behavior fix: event delta of 0 means 'stop gesture' HOT 1
- Carthage support for DrawKit? HOT 2
- Swift Support HOT 4
- DKTextShape does not increase the size when text is too big. HOT 1
- Looking for contributors and pull requests HOT 2
- Where's the right place to instantiate `DKUndoManager`? HOT 1
- Black Rectangle when placed in Containing View HOT 1
- Question - SVG support? HOT 4
- Question - notification for when object clicked (not double clicked)? HOT 1
- Documentation? HOT 3
- How to set an NSAttributedString? HOT 1
- How to access image that was dragged into DKDrawingView[Help Needed] HOT 4
- DKImageShape - Drag and Drop - CGContextSetCTM: invalid context 0x0
- Implementation of DKSecretSelectorsDrawingLayer. HOT 2
- Performance issues on retina display HOT 1
- Edit Text is not working
- Separate Layers
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from drawkit.