Comments replaceMore gives an error about draw

[StefanLobbenmeier]

Hi :)

Can you give the id of a submission where this happens? Or does it happen with every submission?

Edit: also, can you elaborate what you are trying to achieve? I just checked how I do it and I replace the MoreComments one like this:

final MoreComments moreComments;
List<dynamic> expandedComments;
moreComments.comments().then((_expandedComments) {
    expandedComments = _expandedComments;
  });

[StefanLobbenmeier]

Ok the issue seems to be here:

/// Returns the [CommentForest] representing the comments for this
  /// [Submission]. May be null (see [refreshComments]).
  CommentForest get comments => _comments;

But since you called refresh Comments it should not be null anymore. Anyway, the issue is not the replaceMore, but that the comments are null after calling refreshComments.

Edit: I might be stupid and the getter comments is actually called within moreComments... Let me check
Edit2: Yes indeed, it looks like parent.replies is null, since the issue is here:

DRAW/lib/src/models/comment_forest.dart

Line 53 in c52d388

parent.replies._comments.add(comment);

[bkonyi]

Sorry for the delay on this. I'll take a look ASAP.

[bkonyi]

@StefanLobbenmeier, was this resolved by your PR or was this another failure?

[StefanLobbenmeier]

It was not resolved by my PR, at least not intentionally.

[bkonyi]

It was not resolved by my PR, at least not intentionally.

I didn't think so, but figured I'd check. Were you ever able to reproduce this with a specific submission? If so, can you post it here so I can take a look?

[bkonyi]

Quick bump on this issue. @StefanLobbenmeier, have you been able to reproduce? Otherwise I'll close this for now.

[StefanLobbenmeier]

Sorry, I have been gone for some time, but I will hopefully be more active again now :) I did not attempt to reproduce, I was also hoping for @Ivaskuu to provide a specific submission

[bkonyi]

Sorry, I have been gone for some time, but I will hopefully be more active again now :) I did not attempt to reproduce, I was also hoping for @Ivaskuu to provide a specific submission

Not a problem, just figured I'd check! I think I'm going to close this for now, but if someone runs into this error again feel free to reopen with reproduction steps.