Comments (4)
Only changed that one thing in v5.4.2 so I think it's caused by a change in War3Net.IO.Mpq, War3Net.Build.Core v5.4.1 depended on War3Net.IO.Mpq v5.4.0, but latest version is v5.4.3
Since I skipped uploading v5.4.1 and v5.4.2 and nuget is being annoying about 2fa I'm attaching the packages here, I assume you know how to add a local folder source for nuget packages. Can you try out in which version the issue was introduced? (By using War3Net.Build v5.4.1 in combination with War3Net.IO.Mpq v5.4.1 / v5.4.2 / v5.4.3)
war3net.io.mpq.zip
from war3net.
Yep, no problem.
I only experience the issue with War3Net.IO.MPQ version 5.4.3. If I downgrade it to 5.4.2 or 5.4.1, everything works fine. I did all 3 of my tests with War3Net.Build 5.4.1 as instructed.
from war3net.
The issue was in War3Net.Build.Core after all, only occured since War3Net.IO.Mpq v5.4.3 because reading from the mpqstream for mpq files with SingleUnit flag (which includes files which are based on (in this case) a memorystream instead of an mpq archive) was made lazy so it happens on first read instead of in the ctor. At that point the base memorystream was already disposed.
Fixed in v5.4.3: 73cfc61
from war3net.
Awesome, I can compile again. Cheers. FYI I had to add War3Net.Build.Core 5.4.3 to my package references manually - the implicit reference from War3Net.Build 5.4.2 didn't seem to cut it.
from war3net.
Related Issues (20)
- Implement .wgc HOT 6
- Value '3' is not defined for enum of type ObjectDataFormatVersion HOT 2
- Issues with exporting to .json HOT 5
- Cannot cast Char to Tileset & anything to enum really HOT 4
- Invalid Cast Exception (Imported BLPs) HOT 6
- Unable to parse value '0.15' HOT 3
- 'Value '6115' is not defined for enum of type EditorVersion.' HOT 1
- Compiler can crash rather than offering error message HOT 1
- Map builder broken HOT 2
- All destructible on compiled maps are duplicated HOT 8
- MapBuilder method 'AddFiles' fails to add files correctly. HOT 1
- Update .w3i Info file parser HOT 5
- Map.Open does not read object names or tooltips HOT 3
- Editing custom tile pathing HOT 2
- War3 Server HOT 1
- Is it possible to build a Map as a folder instead of a .w3x file? HOT 2
- Zopfli Compression HOT 2
- Expose more should be internal API to become public HOT 2
- What's the difference between Field/LevelField/ArrayLevelField?
- OpenFile() in MpqArchive seems to keep file handle open even when calling Close/Dispose HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from war3net.