Comments (6)
We should not put private links in our public repo (for security considerations).
from dragonfly.
@adiholden @romange I have found only one possible issue. We have 2 steps:
- Check key presence
- trans->execute()
During 2nd step we lock db_slice::cb_mu_ and can preempt so if the key is removed we will execute a transaction with a deprecated iterator.
This bug should be fixed by #3229
from dragonfly.
I haven't found using of cluster, replication but the save operation happened on July 10, 2024 2:59:31 PM (GMT)
from dragonfly.
I've found one more bug with KEY_MOVE error and have fixed it #3334
But it looks like we have at least one more
from dragonfly.
I haven't found the real reason for this bug, but it looks like the execution order was next:
- run trans->WaitOnWatch(...)
- run trans->CancelBlocking(...)
2.1) Transaction::coordinator_state_ |= COORD_CANCELLED;
2.2) Transaction::local_result_ = status; // where status != OK - Transaction::local_result_ somehow should be set OK
- trans->WaitOnWatch(..) returns Transaction::local_result_ // that is already OK
The problem is that I don't see how the 3rd step can happen.
Also, it looks like the 2nd step was done from the connection closing code:
owner->RegisterBreakHook([res, this](uint32_t) {
if (res->transaction)
res->transaction->CancelBlocking(nullptr);
this->server_family().BreakOnShutdown();
});
from dragonfly.
ok, how can you prove that 2 has happened, and it was due to RegisterBreakHook?
from dragonfly.
Related Issues (20)
- extend HSETEX with NX option HOT 1
- Enable OpenSSF Scorecard to enhance security practices across the project HOT 2
- Server crash while running replica takeover and info replication
- get rid of inline tables that use dynamic allocation HOT 1
- Flush important INFO loggings
- Include TLS information into INFO command output HOT 4
- test_cluster_flushall_during_migration deadlock HOT 1
- generic_test.py::test_unknown_dfly_env HOT 1
- teiered storage test failure HOT 2
- failure on test_cluster_fuzzymigration
- failure on test_network_disconnect_during_migration
- Takeover attempt timedout on non responding connections
- Support compression on serialization of big values HOT 6
- Sanitizers crash and namespaces HOT 1
- Failure on test_take_over_seeder HOT 4
- Replace SharedMutex in Journal
- DragonflyDB crashes when running BullMQ tests on a MacOS HOT 5
- untracked memory or a leak HOT 1
- test_multi_db failure
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dragonfly.