remove blank space after the icons in the menu about freecad

[eleanor-clifford]

This is great, can we get a PR? I'd do it myself but I'm a bit short on time nowadays

[Chrismettal]

So you removed the "Fix" in your stylesheet and the blank space goes away for you? Can you show us the code you edited?

The stylesheets are basically always created based on another sheet, and not recreated from scratch, so this might potentially be just dead weight carried since inception.

I think there is another "stylesheet" wide bug (?) were tab width is significantly wider for stylesheets, so you need to scroll in the preference menu if kept at default dimensions, for example:

WIthout a stylesheet, the default width is perfect to fit all tabs without scrolling:

So both of these might be stuff that is copied through all stylesheets since the beginning

[MisterMakerNL]

Jup, I'll post the link I shared on Twitter for reference: https://forum.freecadweb.org/viewtopic.php?p=597530#p597530
Can find my stylesheet here: https://github.com/MisterMakerNL/ExtremeProDark
MY goal of the stylesheet was to optimize screen-space, so it's all a bit compacted.

[Chrismettal]

This goes a bit deeper than I thought.

Yes, all stylesheets have that blank space, yes removing that padding fixes the blank space, but in any case, no stylesheet correctly shows most of the checkboxes in dropdown menus.

Here is the original without any stylesheet:

This is any random stylesheet, showing no boxes but the blank space AFTER the Icon

And this is your fix, removing the blank space as well.

So, in no stylesheet can we currently see checked items in dropdown menus in the main window right now.
Interestingly, the item at the bottom without any icon has a working checkbox. It is just checkboxes WITH icons that get eaten up.

EDIT:
Related: https://bugreports.qt.io/browse/QTBUG-66380
According to this, styling with boxes and icons is impossible in current QT, and instead the icon (or its frame or background) should show the state. In that case we could remove the blank space and add a colored border showing the icon's state in all stylesheets.

[MisterMakerNL]

Wow nice work!
Instead of a colored border could we make it look like a pressed in button?
btw this is how it looks on windows in freecad 0.2 without stylesheet.

[MisterMakerNL]

I think I fixed it! (for windows)
Add this to the qss:
QMenu::icon:checked { /* appearance of a 'checked' icon */
background: gray;
border: 1px inset gray;
position: absolute;
top: 1px;
right: 1px;
bottom: 1px;
left: 1px;
}
above is from the wiki of QT below is what I ended up adding to my theme. Only need some Linux testers!!

QMenu::icon:checked { /* appearance of a 'checked' icon */
    background: #6492d7;
    border: 2px #6492d7;
    position: absolute;
    border-radius: 3px;
}

[Chrismettal]

That looks quite good! And matches QTs intention.
I only find the 3 px corner radius a bit much, but that's for your stylesheet to decide. At least for Behave I would keep it smaller, but that I will try out later.

Gonna test on Linux later and implement your fix for the other stylesheets sitting in the FreeCAD source, using a fitting "checked" color for each stylesheet individually, unless you're already on it?

[Chrismettal]

Sure thing!

[MisterMakerNL]

Nice, I am happy it also worked in Linux!

[eleanor-clifford]

closed by #6