Coder Social home page Coder Social logo

Comments (5)

nathanfletcher avatar nathanfletcher commented on August 20, 2024

This is the sandbox I'm fixing it and other minor bugs found
https://github.com/nathanfletcher/publicgoods-scripts

from publicgoods-scripts.

lacabra avatar lacabra commented on August 20, 2024

@nathanfletcher This may be a "non-consequential" error, that may require further investigation. For example, why is it that the error does not appear in the build that the CI does here? (if it appeared, it would error out)

Can you please provide additional information on how this error is triggered?

from publicgoods-scripts.

nathanfletcher avatar nathanfletcher commented on August 20, 2024

@lacabra Creating a GitHub action in this repo to set up the CI in this repo to run npm run build in both folders packages/registry and packages/eligibility means that all the steps from 1-8 in the Readme would have to be followed first, with some slight modifications to include packages/registry and packages/eligibility.

Running npm run build for packages/eligibility after the steps throws this error because it cannot find /wp-content/themes/dpga/font/NowAlt-Regular.woff as the CSS is not able to access folders outside the src folder of packages/eligibility during the npm run build process.

I solved it by including a step in moveFiles.bash here to copy the fonts folder from the static wp-content into packages/eligibility and updated the links to the fonts in the CSS.
That way it won't worry the upstream build command here

from publicgoods-scripts.

nathanfletcher avatar nathanfletcher commented on August 20, 2024

@lacabra Alternatively, a simpler solution would be for @rachita19082 to include the fonts folder with the respective fonts in the project.
That is if the fonts used would not change anytime soon so the current solution I have above wouldn't have to pull it from the static WordPress here

from publicgoods-scripts.

lacabra avatar lacabra commented on August 20, 2024

@nathanfletcher I prefer your solution of copying them only for the purposes of the CI. Alternatively, you could do a soft link of the relative folder (because you have it cloned already -> that's how I have it in my local environment, and works well)

For sure, do not include the fonts in the source code because they don't belong there, and introduces undesired redundancy.

Thanks!

from publicgoods-scripts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.