Coder Social home page Coder Social logo

Comments (11)

dperini avatar dperini commented on July 28, 2024 2

@alopix thank you for the help.
Yes it is the same bug affecting everybody.
Still need a couple of days working on it and testing.

from nwsapi.

dperini avatar dperini commented on July 28, 2024 1

Thank you @domenic ...
I am working on the bugs/fixes you listed.
Especially trying to resolve the is not a valid selector regression.

from nwsapi.

dperini avatar dperini commented on July 28, 2024 1

@alopix
could you also check your problem has been fixed by these latest changes ?
Thank you in advance for the great help and reviews.

from nwsapi.

alopix avatar alopix commented on July 28, 2024 1

@dperini thanks for working on this. I just checked and the selector seems to be working again with jsdom using your main branch 👍

from nwsapi.

alopix avatar alopix commented on July 28, 2024

If it helps your debugging/fixing @dperini, a selector that has started failing with the latest 2.2.10 release is
#main-content [class*="-Wrapper "]~[class*="-Paragraph "] which the is not a valid selector error. Not quit sure which part it does not like.

from nwsapi.

dperini avatar dperini commented on July 28, 2024

@domenic
the parsing bug was fixed and I believe I took care of all the other issues you mentioned above.
You can tell if this is good enough for a new release on npm or if you need other changes/additions.
Next release will be 2.2.12 and I will skip 2.2.11 as a marker of the problem I incurred with failing RE.

from nwsapi.

dperini avatar dperini commented on July 28, 2024

@alopix
thank you so much for the tests.
Your help appreciated.

from nwsapi.

moekify avatar moekify commented on July 28, 2024

@dperini Any update on when you will release 2.2.12? :)

from nwsapi.

dperini avatar dperini commented on July 28, 2024

@moekify
we are near to it ... very near.
Anything you would like to see added or fixed ?
Does nwsapi work for you in its current state.

from nwsapi.

moekify avatar moekify commented on July 28, 2024

No we definitely need the fix :) but not crazy urgent, just wanted to be able to communicate something upstream.

Thanks for your work on this :)

from nwsapi.

dperini avatar dperini commented on July 28, 2024

@domenic
nwsapi Release 2.2.12 has just been pushed to npm.

from nwsapi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.