Comments (11)
@alopix thank you for the help.
Yes it is the same bug affecting everybody.
Still need a couple of days working on it and testing.
from nwsapi.
Thank you @domenic ...
I am working on the bugs/fixes you listed.
Especially trying to resolve the is not a valid selector regression.
from nwsapi.
@alopix
could you also check your problem has been fixed by these latest changes ?
Thank you in advance for the great help and reviews.
from nwsapi.
@dperini thanks for working on this. I just checked and the selector seems to be working again with jsdom using your main branch 👍
from nwsapi.
If it helps your debugging/fixing @dperini, a selector that has started failing with the latest 2.2.10 release is
#main-content [class*="-Wrapper "]~[class*="-Paragraph "]
which the is not a valid selector error. Not quit sure which part it does not like.
from nwsapi.
@domenic
the parsing bug was fixed and I believe I took care of all the other issues you mentioned above.
You can tell if this is good enough for a new release on npm or if you need other changes/additions.
Next release will be 2.2.12 and I will skip 2.2.11 as a marker of the problem I incurred with failing RE.
from nwsapi.
@alopix
thank you so much for the tests.
Your help appreciated.
from nwsapi.
@dperini Any update on when you will release 2.2.12? :)
from nwsapi.
@moekify
we are near to it ... very near.
Anything you would like to see added or fixed ?
Does nwsapi work for you in its current state.
from nwsapi.
No we definitely need the fix :) but not crazy urgent, just wanted to be able to communicate something upstream.
Thanks for your work on this :)
from nwsapi.
@domenic
nwsapi Release 2.2.12 has just been pushed to npm.
from nwsapi.
Related Issues (20)
- :scope can't distinguish a context with no IDs nor classnames
- :enabled / :disabled do not correctly match inputs inside a disabled fieldset
- :active always returning true since 2.2.7 HOT 8
- case insensitive tag names doesn't seem to work after updating to 2.2.7 from 2.2.2 HOT 7
- The `:nth-child(even)` selector no longer works HOT 1
- Revert to v2.2.2 HOT 14
- Selector with escaped special characters gives SyntaxError
- :scope not working when the context has a class name that uses special characters HOT 3
- Child combinator `>` inside `:not()` is not a valid selector HOT 3
- Regression (2.2.8) surfaced by jsdom: `h1` is not a valid selector HOT 10
- Websites not working (`403` and `404`)
- v2.2.8 introduces SyntaxError: ':focus-visible' is not a valid selector HOT 6
- `SyntaxError: missing ) after argument list` due to missing escaping in `:has()` pseudo-class HOT 1
- h1 + h2 appears to break HOT 4
- SyntaxError: '>input:-webkit-autofill' is not a valid selector HOT 6
- policy violation nwsapi 2.2.10
- :active and :hover always returning true since 2.2.10 HOT 7
- '' is not a valid selector
- querySelector(<Tag>) is case-sensitive since 2.2.10 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nwsapi.