isLocationEnabled needs GPS enabled for returning true on Android about cordova-diagnostic-plugin

[dpa99c]

Hi Wanja,

I originally intended isLocationEnabled() on Android to be an equivalent of the iOS variant - it was intended to mean "is the app good to go for high-accuracy location tracking", e.g. a navigation app. On iOS, isLocationEnabled() returns true if the app is authorized to use location AND location services are enabled. On iOS there's no way to tell if the device is using high-accuracy (GPS) or low-accuracy (network/WiFi) but on Android there is.

I guess I could change the semantics of isLocationEnabled() for Android, but given that many people are using this plugin in their apps, it may cause them issues. So I think maybe it would be better if I explicitly exposed isGpsEnabled() and isNetworkEnabled() via the JS API as isGpsEnabled() and isNetworkLocationEnabled()

Then you could do something like this:

cordova.plugins.diagnostic.isNetworkLocationEnabled(function(networkLocationEnabled){
    cordova.plugins.diagnostic.isGpsEnabled(function(gpsEnabled){
        if(gpsEnabled){
            console.log("High accuracy location enabled");
        }else if(networkLocationEnabled){
            console.log("Low accuracy location enabled");
        }else{
            console.log("No location enabled");
        }
    }, errorCallback);
}, errorCallback);

What do you think?

[iwan-uschka]

Hey, thanks for answering.
You're totally right. You cannot change 'isLocationEnabled()' if so many people would be affected.
To provide isGpsEnabled() and isNetworkLocationEnabled() via JS API would be great.
Please add this feature.
Thank you for a great plugin anyway.

Cheers from berlin
wanja

[dpa99c]

OK, I decided to update isLocationEnabled() on Android to return true either if GPS or network location is enabled. This is consistent with the iOS implementation. I've also added functions to individually check GPS and Network location states on Android. This has been done as a major version increase to 2.0.0, so anyone relying on the old interface can use cordova.plugins.diagnostic@1

[iwan-uschka]

Thanks!