Coder Social home page Coder Social logo

Comments (7)

dpa99c avatar dpa99c commented on August 15, 2024

The plugin uses an after_prepare hook to apply any custom config defined in config.xml to each platform folder under platforms/. Regardless of whether you run cordova build android, cordova build ios, or cordova build, the hook script is executed the same by Cordova. The arguments that Cordova passes to the hook script does not include which platforms it is operating on, so the only way for the plugin hook script to know which platforms are currently being operated on would be to scrape and parse the cordova CLI command-line arguments, which is a bit evil. Therefore, since if you have any custom config defined for other platforms, you probably want to apply it anyway, it's probably OK for now that the plugin runs against all platforms regardless of which platforms Cordova is operating on.

from cordova-custom-config.

pke avatar pke commented on August 15, 2024

ok, so that's not really an issue than? Nothing can go wrong and we can just ignore the message?

from cordova-custom-config.

dpa99c avatar dpa99c commented on August 15, 2024

yeah, so long as it isn't actually causing a build failure, I think it's OK as it is for now.

from cordova-custom-config.

pke avatar pke commented on August 15, 2024

Hmm I see that cordova passes the platforms to the hook in CORDOVA_PLATFORMS.
Also see here: https://cordova.apache.org/docs/en/latest/guide/appdev/hooks/#sample-usage

from cordova-custom-config.

dpa99c avatar dpa99c commented on August 15, 2024

My bad, so Cordova does inform which platforms are being built. However, as stated above, since this isn't causing any issues other than applying config to platforms not currently being built, it's far from the top of my priority list.

from cordova-custom-config.

pke avatar pke commented on August 15, 2024

Created #59 to solve this ;)

from cordova-custom-config.

dpa99c avatar dpa99c commented on August 15, 2024

Resolved by #59 - thanks to @pke

from cordova-custom-config.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.