Comments (4)
I'm beginning to think that this auto-backup/restore feature is more hassle than it's worth. It's a feature someone asked for in the very early stages of the plugin, but I think at the very least I will turn it off default (as opposed to current default of on). Then also, as you suggest, wipe any backups between platform removal/updates.
from cordova-custom-config.
I would agree - turn it off by default. I personally don't understand what benefit it offers. If it's removed when the platform is updated, what good was that backup for anyway?
I think a backup/restore would be better implemented manually by someone with their own custom hooks. They obviously have some kind of special scenario going on.
from cordova-custom-config.
The idea of the backup/restore was to allow "removable" custom config. Let's say you add a preference or config block that has an undesirable effect or you no longer want to apply it. But the plugin has already injected the relevant config into the platform-specific files (e.g. AndroidManifest.xml). Without the backup/restore mechanism, the only way to remove it (without removing/re-adding the platform) is to manually edit the platform configs. The conversion of custom config in the config.xml into the platform-specific translation is not always obvious to plugin users, so manual removal can be tricky for them. Of course, one option is to remove/re-add the platform. I myself never manually touch anything under platforms/
- I consider those sub-folders to be volatile. But plenty of people make manual changes to platform configs (particularly on iOS via XCode) so they see removing/re-adding platforms as a major hassle. Anyway, that's the history of it.
But, agreed, it should be switched off by default, which I'll do in the next release.
from cordova-custom-config.
Got it. That makes sense.
I use to fall into that bucket of making manual changes, but as things have matured (and with plugins like this), it should no longer be necessary anymore.
Thanks for the quick reply.
from cordova-custom-config.
Related Issues (20)
- Snyk report: High severity vulnerability found in shelljs -> Command Injection HOT 1
- Snyk report: High severity vulnerability found in plist -> Regular Expression DOS HOT 1
- Android: custom-preference isn't doing anything, no error given HOT 1
- not compatible with cordova 9
- iOS location issue on uploading the apptore - ask for NSLocationAlwaysUsageDescription HOT 2
- All of a sudden (after updating node/npm LTS and cordova to 8.1.2), upon 'cordova run android', "Error loading dependencies (Cannot find module 'tostr') - attempting to resolve" - must install all deps by hand now HOT 6
- cordova-custom-config: Error updating config for platform 'android': Cannot use absolute path on element HOT 2
- Cordova builds fail with XCode-beta 11 HOT 4
- i need help with error unboun prefix HOT 1
- Question: iOS - how to set Legacy Build System ? HOT 5
- Builds fail when attempting usesClearText=true HOT 1
- Cordova ios build error - can someone help HOT 1
- Question: is this plugin needed for UISupportedInterfaceOrientations? HOT 2
- support capacitor HOT 1
- [Bug][Android] '"{{proj_path}}\platforms\android\cordova\version"' is not recognized as an internal or external command, operable program or batch file. HOT 1
- Cannot insert new Item to the section on AndroidManifest
- Vulnerability with package 'colors' HOT 1
- vulnerability in xcode package HOT 1
- Config.xml Bug HOT 6
- Ionic - The prefix "tools" for attribute "tools:node" associated with an element type "uses-permission" is not bound. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cordova-custom-config.