Coder Social home page Coder Social logo

Python API and PEP 8 about fluid-engine-dev HOT 13 OPEN

doyubkim avatar doyubkim commented on May 23, 2024
Python API and PEP 8

from fluid-engine-dev.

Comments (13)

doyubkim avatar doyubkim commented on May 23, 2024

@utilForever volunteered to work on this issue!

@utilForever, currently dev-v2-gpu is the main dev branch for the v2 release. This contains new C++ APIs (such as new vector/matrix implementations) so it would be great to start from there. You can branch out from dev-v2-gpu and create something like dev-v2-gpu-pep8, make changes, and raise PR against dev-v2-gpu (not the master of course).

from fluid-engine-dev.

utilForever avatar utilForever commented on May 23, 2024

@doyubkim Alright. I'll start working today.

from fluid-engine-dev.

doyubkim avatar doyubkim commented on May 23, 2024

@utilForever Also checking in to see where we're at on this. Thanks again for taking this effort!

from fluid-engine-dev.

utilForever avatar utilForever commented on May 23, 2024

@doyubkim Thanks. I'll work on this weekend. Please understand that my health is not very good.

from fluid-engine-dev.

doyubkim avatar doyubkim commented on May 23, 2024

Same as the other issue: @utilForever I am terribly sorry to hear that :( You should take a good break and not look at any codes. I will take this issue and raise a PR. Please take a good rest and get well soon!

from fluid-engine-dev.

utilForever avatar utilForever commented on May 23, 2024

Same as the other issue: @doyubkim Thanks. I'm OK now. So, please take this issue to me. 😄

from fluid-engine-dev.

doyubkim avatar doyubkim commented on May 23, 2024

@utilForever I am currently working on unifying redundant 2-D and 3-D codes and this will introduce quite a lot of changes in the Python binding lib. If you haven't started working on this issue, I recommend not starting it until the unifying work is completed.

from fluid-engine-dev.

utilForever avatar utilForever commented on May 23, 2024

@doyubkim I'm already working on this issue. I'll consider your unifying work. 🎉

from fluid-engine-dev.

doyubkim avatar doyubkim commented on May 23, 2024

@utilForever the latest dev branch is now merged into the dev-v2-gpu branch. This contains some breaking changes in Python APIs so you may need to adapt to it. What's the latest status of this PEP8 work?

from fluid-engine-dev.

utilForever avatar utilForever commented on May 23, 2024

@doyubkim I'm now finished with exception of some grids. However, I'm working on changing the structure from 3 days ago.

from fluid-engine-dev.

doyubkim avatar doyubkim commented on May 23, 2024

@utilForever thanks for the update!

from fluid-engine-dev.

utilForever avatar utilForever commented on May 23, 2024

@doyubkim Update: My work is almost finished. Can I do a pull request to dev-v2-gpu branch?

from fluid-engine-dev.

doyubkim avatar doyubkim commented on May 23, 2024

Thanks for the update! Yes, that should be the target branch.

from fluid-engine-dev.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.