Coder Social home page Coder Social logo

Comments (3)

doyaaaaaken avatar doyaaaaaken commented on May 18, 2024 2

@NightEule5
I tried too and got an error.
Though, Inline function makes code performance better, but funcitons like csvReader , open are not often called. So the performance affect is very small.

It seems to work well with just the diffs on the following three files in your branch, so I'd like to merge only this fix this time.

  • build.gradle.kts
  • CsvReaderDsl.kt
  • CsvWriterDsl.kt

from kotlin-csv.

doyaaaaaken avatar doyaaaaaken commented on May 18, 2024

Thank you very much for your useful remarks.
That was a perspective that had been missing.

I'm not familiar with the behavior of inline functions, so I'll look into it right away and figure out how to handle it.

from kotlin-csv.

NightEule5 avatar NightEule5 commented on May 18, 2024

Thanks for the reply. I forked the repository, but couldn't get the open functions to work with the tests when inlined ("Wrong bytecode generated" error). Admittedly, my experience with tests is limited though.

from kotlin-csv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.