[portability] Use existing cv::putText about cvui

[ebachard]

ooops, looks like something was wrong with the code instertion ... apologies :-/

[ebachard]

Apologies, I'll read how to send patch, because I'm more used to speak patch language than html things.

[Dovyski]

Hello! Don't worry about formatting nor any Github idiosyncrasy, your contribution is the valuable part.

I would like you to elaborate a bit more regarding cvui::printf portability. Is it not portable because of a misbehavior or compilation warning/error on Linux/Mac?

I see the benefit of using cv::putText, but the general idea of cvui is to abstract opencv drawing primities to provide a simpler and more powerful API. I think the methods you suggested (intToString() and floatToString()) could be replaced by the already existing std::to_string():

// ... 
cv::putText(frame,
 "cvuiv" + std::to_string(VERSION_MAJOR) + "." + std::to_string(VERSION_MINOR) + "." + std::to_string(VERSION_MICRO),
  cv::Point(frame.cols - 80,frame.rows - 10 /*FIXME : use font height instead of a magic */),
  fontFace,
  0.4,
  aColor,
  1.5,
  8);

//...   

[ebachard]

Le 31/10/2016 20:16, Fernando Bevilacqua a écrit :

Hello! Don't worry about formatting nor any Github idiosyncrasy, your contribution is the valuable part.

Hello Fernando,

Apologies for the loooong delay : several things made me away from
keyboard, and I hope I'll have more time this week.

(of course, I'll answer the other mails you sent me asap)

I would like you to elaborate a bit more regarding cvui::printf portability. Is it not portable because of a misbehavior or compilation warning/error on Linux/Mac?

The problem is most of the time Microsoft, deciding something, without
verify the portability is respected on other OS's, and what I read here
and there told me it's simply not possible to use this directly. As I
wrote, I was busy last week, but I'll try to propose another solution
-means something simly working on Unix'es- once I'll have the time to
work on that. e.g., currently, some strings displaying is broken, due to
the uggly workaround I used (first thing was to make it compile, per see
:-)

I see the benefit of using cv::putText, but the general idea of cvui is to abstract opencv drawing primities to provide a simpler and more powerful API. I think the methods you suggested (intToString() and floatToString()) could be replaced by the already existing std::to_string():

OOOops, my bad :-)

I was simply unaware such solution was existing. Of course it is more
simple to use that, under to condition to build adding "-std=c++11 " in
the command line.

// ...
cv::putText(frame,
  "cvuiv" + std::to_string(VERSION_MAJOR) + "." + std::to_string(VERSION_MINOR) + "." + std::to_string(VERSION_MICRO),
   cv::Point(frame.cols - 80,frame.rows - 10 /*FIXME : use font height instead of a magic */),
   fontFace,
   0.4,
   aColor,
   1.5,
   8);

Tested one minute ago => works as expected on Linux (not tested on Mac OS X)

Regards,
Eric Bachard

//...

[Dovyski]

I think all the issues reported here were fixed by 80f382f. If you face any problems, please open a new issue.