Coder Social home page Coder Social logo

Comments (3)

douweschulte avatar douweschulte commented on June 2, 2024 1

I additionally removed the requirement for the following columns:

  • atom_site.occupancy
  • atom_site.B_iso_or_equiv

Leaving the Cartn columns to be the only columns that are required on top of the mmCIF requirements. But those are (according to your link) present in 100% of the files, and very sensible to be defined if you want to use this library. In the future this requirement could be removed in favour of requiring any position, fract or Cartn, but that can wait.

Thanks for the issue, this gave me a push to do some nice refactorings in the parse_atoms function and you pointed me to a nice docs site that I never found before.

from pdbtbx.

douweschulte avatar douweschulte commented on June 2, 2024

I do agree, I will work on removing the requirements and figuring out sensible ways of dealing with missing data.

from pdbtbx.

douweschulte avatar douweschulte commented on June 2, 2024

I removed the requirements on the following columns:

  • atom_site.pdbx_formal_charge
  • atom_site.group_PDB

The other columns are (according to your link) always present. Although I will think about relaxing the requirements some more while refactoring the code some more.

from pdbtbx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.