Rewrite breaks insert into statement about go-mad

[shyim]

I guess this would fix it.

Index: database/mysql.go
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/database/mysql.go b/database/mysql.go
--- a/database/mysql.go	(revision 9284e51bb1d5409d4ccf2b6f61f0517070a48eef)
+++ b/database/mysql.go	(date 1644248808874)
@@ -328,7 +328,13 @@
 }
 
 func (d *mySQL) dumpTableData(w io.Writer, table string) error {
-	rows, columns, err := d.selectAllDataFor(table)
+	columns, err := d.getColumnsForSelect(table, false)
+
+	if err != nil {
+		return err
+	}
+
+	rows, _, err := d.selectAllDataFor(table)
 	if a := d.evaluateErrors(err, rows); a != nil {
 		return a
 	}
@@ -442,7 +448,7 @@
 }
 
 func (d *mySQL) getSelectQueryFor(table string) (cols []string, query string, err error) {
-	cols, err = d.getColumnsForSelect(table)
+	cols, err = d.getColumnsForSelect(table, true)
 	if err != nil {
 		return cols, "", err
 	}
@@ -461,7 +467,7 @@
 	return "UNLOCK TABLES;\n"
 }
 
-func (d *mySQL) getColumnsForSelect(table string) (columns []string, err error) {
+func (d *mySQL) getColumnsForSelect(table string, considerRewriteMap bool) (columns []string, err error) {
 	rows, err := d.db.Query(fmt.Sprintf("SELECT * FROM `%s` LIMIT 1", table))
 	if a := d.evaluateErrors(err, rows); a != nil {
 		return columns, a
@@ -484,7 +490,11 @@
 		}
 
 		replacement, ok := d.selectMap[strings.ToLower(table)][strings.ToLower(column)]
-		if ok {
+		if ok && considerRewriteMap {
+			if len(replacement) >= 5 && replacement[0:5] == "faker" {
+				replacement = fmt.Sprintf("'%s'", replacement)
+			}
+
 			columns = append(columns, fmt.Sprintf("%s AS `%s`", replacement, column))
 		} else {
 			columns = append(columns, fmt.Sprintf("`%s`", column))

What you think?

[shyim]

or getColumnsForSelect returns a struct with two functions then getRewritedColumns, getColumns

[bolovsky]

Both solutions are legit, the second one may be a bit cleaner but will increase (slightly) the memory footprint.

If you want to open a PR ❤️, go for the one you feel would be the best 🙂

[shyim]

I am struggling with the current tests. They fail weird 😅