RunSynchronously may not be called on a task that has already completed about watsonwebserver

[jchristn]

Oooh, ouch. Thanks for sending this. Just confirmed this and will investigate!

[jchristn]

Hi @at1993 I confirmed that the ResponseSent event never fires but am unable to reproduce the InvalidOperationException when a GET request comes in. Can you provide steps to reproduce?

[at1993]

Thanks for looking into the problem so promptly. The error may have suppressed when you test it in released mode. I tried it in debug mode via Visual Studio 2019.

[jchristn]

Thanks @at1993 - so this issue is not limited to just the Test.Events project, but any project including Test.Default (just confirmed).

So there are two issues:

1. Even though the requests are being responded to and handled by the default route, somehow an InvalidOperationException is being thrown, and
2. The ResponseSent callback is never being called

Can you confirm that requests are being handled as expected by your code aside from these two issues? Thanks!

[jchristn]

For issue #1, changing from .RunSynchronously() to .Wait() resolves the issue.

For issue #2, I'll need to amend HttpResponse to keep a flag indicating whether or not a response was sent, and check the flag at the end of ThreadPool.QueueUserWorkItem((c) => ...

[at1993]

Thanks @jchristn .Wait() works for me. Just curious, Within the HttpResponse class, it does not signal (ResponseSent) at all when sending data is completed.

[jchristn]

Correct, I have to fix that :) This and one other fix will be going into my next release. Cheers!

[jchristn]

NuGet package published: https://www.nuget.org/packages/Watson/3.0.5

Commit: 657b75f

Changes:

- Removed ThreadPool.QueueUserWorkItem in favor of unawaited Tasks
- Removed .RunSynchronously in favor of .Wait for the default route, thereby eliminating an InvalidOperationException (thank you @at1993)
- Properly firing ResponseSent events when the event callback is defined (thank you @at1993)
- Fixed an issue where the file path for content routes was not properly constructed (thank you @zaksnet)
- Added better documentation on event callbacks

Thanks for your help and re-open this issue if there are any problems! Cheers