Coder Social home page Coder Social logo

Comments (30)

antmeehan avatar antmeehan commented on June 8, 2024 8

There seems to be a change in the Central Package Management behaviour in SDK 8.0.300 around the existence of Directory.Packages.props file. We had one in our solution but it didn't have anything defined, ie:

<Project>
</Project>

dotnet restore was happy under previous SDK versions, but now under 8.0.300 it starts complaining about the incorrect use of Central Package Management (as if it is enabled), eg:

error NU1008: Projects that use central package version management should not define the version on the PackageReference items but on the PackageVersion items

Deleting the Directory.Packages.props has fixed the issue.

from core.

bording avatar bording commented on June 8, 2024 5

Why did this release include the 8.0.300 SDK but the matching Visual Studio 17.9.7 update shipped with 8.0.205?

If I install 8.0.300 manually, it doesn't work properly in Visual Studio because it looks like the compiler version is too old, causing the SDK analyzers to not work.

For example:

The analyzer assembly 'C:\Program Files\dotnet\sdk\8.0.300\Sdks\Microsoft.NET.Sdk\codestyle\cs\Microsoft.CodeAnalysis.CodeStyle.dll' references version '4.10.0.0' of the compiler, which is newer than the currently running version '4.9.0.0'.	ServiceControl.Audit.Persistence.SagaAudit	C:\Program Files\dotnet\sdk\8.0.300\Sdks\Microsoft.NET.Sdk\codestyle\cs\Microsoft.CodeAnalysis.CodeStyle.dll

We currently have our CI builds set up to pick up the latest SDK, so this results in us having failing builds due to the analyzers in the updated SDK finding more cases of triggering patterns, but then us not being able to see them locally in Visual Studio and apply fixers.

It also appears the compiler in the 8.0.300 SDK has a new language breaking change that has impacted us as well, and it's a pain to figure out what's going on when I can't use the matching SDK in Visual Studio.

from core.

andreaskromann avatar andreaskromann commented on June 8, 2024 3

@antmeehan it seems to be this change: NuGet/NuGet.Client#5572

from core.

Talouv-work avatar Talouv-work commented on June 8, 2024 3

As @antmeehan and @andreaskromann point out with NuGet/NuGet.Client#5572, I think it's worth noting that the default value of <ManagePackageVersionsCentrally /> has essentially changed such that whenever a file called Directory.Packages.props is present, the default value is now true (8.0.300) as opposed to false (prior to 8.0.300).

This was in fact a breaking change for us, because some of our legacy projects in our mono repository haven't been migrated to use the centralized package management, causing some of our builds to fail when building with the 8.0.300 SDK. We relied on the default value and using a more specific Directory.Build.props to ensure that these legacy projects did not use the central nuget package versioning.

Now, for anyone reading this, it's easily fixed by explicitly setting <ManagePackageVersionsCentrally>false</ManagePackageVersionsCentrally> in the Directory.Build.props file where you do not want to use CPM, but it is indeed something you MUST do before upgrading the dotnet SDK.

from core.

OronDF343 avatar OronDF343 commented on June 8, 2024 3

The blog post no longer contains links to the list of actual non-security changes in the release. Previously, there were links to the merged PRs in each repo, which wasn't ideal but at least was useful. Now, I have no easy way to see the list of actual changes without going to each repo and manually searching the PRs by milestone.

Please reconsider this change in communication, and ideally consider a way to list all of the changes in a simple list. Thanks

from core.

libreo-abrettschneider avatar libreo-abrettschneider commented on June 8, 2024 2

Is it possible that this update changed the way code style analyzers work at least for 8.0.5? Out of sudden analyzers that didn't trigger before are now producing warnings or in our case errors preventing our build from working even so there weren't any changes. e.g.: error IDE0100: Remove redundant equality

from core.

mairaw avatar mairaw commented on June 8, 2024 1

@SusanBradley the blog post is now live athttps://devblogs.microsoft.com/dotnet/dotnet-and-dotnet-framework-may-2024-servicing-updates/

from core.

lbussell avatar lbussell commented on June 8, 2024 1

Any reason why 8.0.4 or 8.0.5 is not listed here https://hub.docker.com/_/microsoft-dotnet-runtime ?

@pebezo The images are up to date, but the syndication from the Microsoft Asset Registry to DockerHub is currently not working. See dotnet/dotnet-docker#5327.

You can view the latest tags on MAR: https://mcr.microsoft.com/product/dotnet/runtime/tags

from core.

ztatvialto avatar ztatvialto commented on June 8, 2024 1

Can we have link to what's the new feature released in 8.0.300, compared to 8.0.205, it should be a new feature release, so what's the new feature?

from core.

mattzink avatar mattzink commented on June 8, 2024

Is the full changelog link for the 7.0.19 release supposed to be comparing v6.0.29 -> v7.0.19? I guess I was expecting 7.0.18 -> 7.0.19?
https://github.com/dotnet/core/releases/tag/v7.0.19

from core.

Serge-N avatar Serge-N commented on June 8, 2024

Publish the blog too .

from core.

SusanBradley avatar SusanBradley commented on June 8, 2024

Can we get a priority on publishing the blog on the day that updates are released? https://devblogs.microsoft.com/dotnet/May-2024-updates/ that's MIA. I'm not a developer, I'm a patcher and I rely on the communication from the .NET blog to know what updates I should be expecting.

from core.

SusanBradley avatar SusanBradley commented on June 8, 2024

@mairaw https://support.microsoft.com/en-us/topic/-net-6-0-update-may-14-2024-kb5038350-a08fa6e5-7c7e-4ecb-a15e-268507cd39ab that says that the .net 6 also has security updates, not just 7 and 8?

from core.

rbhanda avatar rbhanda commented on June 8, 2024

@mairaw https://support.microsoft.com/en-us/topic/-net-6-0-update-may-14-2024-kb5038350-a08fa6e5-7c7e-4ecb-a15e-268507cd39ab that says that the .net 6 also has security updates, not just 7 and 8?

Hello, My apologies for the wrong details in the https://support.microsoft.com/en-us/topic/-net-6-0-update-may-14-2024-kb5038350-a08fa6e5-7c7e-4ecb-a15e-268507cd39ab. I have submitted a request to update this to reflect that 6.0 is a non security release

from core.

pebezo avatar pebezo commented on June 8, 2024

Any reason why 8.0.4 or 8.0.5 is not listed here https://hub.docker.com/_/microsoft-dotnet-runtime ?

from core.

leecow avatar leecow commented on June 8, 2024

Can we get a priority on publishing the blog on the day that updates are released? https://devblogs.microsoft.com/dotnet/May-2024-updates/ that's MIA. I'm not a developer, I'm a patcher and I rely on the communication from the .NET blog to know what updates I should be expecting.

@SusanBradley - the May blog URL is https://devblogs.microsoft.com/dotnet/dotnet-and-dotnet-framework-may-2024-servicing-updates/ and looks like it was posted on the 15th. Not sure why it was late - will look into that.

from core.

leecow avatar leecow commented on June 8, 2024

Why did this release include the 8.0.300 SDK but the matching Visual Studio 17.9.7 update shipped with 8.0.205?

@bording - The May Updates included releases for 8.0.105, 8.0.205, and 8.0.300. Way back in the beginnings of .NET Core, we needed to figure out how to support new versions of Visual Studio along with new features in shared tools, such as compilers and analyzers. We refer to the first digit of the 'patch version' as the feature band. Sometimes a new feature band will include updates that effect backward compatibility.

To help know what .NET goes with what VS, we include the mappings in detailed release metadata. This can be seen as a top-level index that references each version channel (8.0 example). This file includes the VS mapping info, for example ...

                    "version": "8.0.205",
                    "version-display": "8.0.205",
                    "runtime-version": "8.0.5",
                    "vs-version": "17.9.7",
                    "vs-mac-version": "",
                    "vs-support": "Visual Studio 2022 (v17.9)",
                    "vs-mac-support": "",
                    "csharp-version": "12.0",
                    "fsharp-version": "8.0",
                    "vb-version": "16.9",

where vs-version indicates which VS update includes this particular SDK and Runtime, and vs-support, which indicates the supported VS minor version.

Hopefully this info helps with your update automation.

from core.

leecow avatar leecow commented on June 8, 2024

The blog post no longer contains links to the list of actual non-security changes in the release. Previously, there were links to the merged PRs in each repo, which wasn't ideal but at least was useful. Now, I have no easy way to see the list of actual changes without going to each repo and manually searching the PRs by milestone.

Please reconsider this change in communication, and ideally consider a way to list all of the changes in a simple list. Thanks

@rbhanda - please take a look.

from core.

mairaw avatar mairaw commented on June 8, 2024

And the VS support info perhaps can be more easily consumed on the dot.net site
https://dotnet.microsoft.com/en-us/download/dotnet/8.0

from core.

mrahl avatar mrahl commented on June 8, 2024

Did 8.0.5 change the GC characteristics? Nothing mentioned in the release notes. But as we're rolling out updated containers we see increased Gen0 and Gen1 sizes as well as longer GC pauses, while Gen2 and LOH are decreasing. See image below. This is averages across thousands of instances that progressively get the new version, so the slope over time is explained as the change in mix of 8.0.4 based containers to 8.0.5 based containers.

image

from core.

leecow avatar leecow commented on June 8, 2024

Did 8.0.5 change the GC characteristics?

I see dotnet/runtime#100575 included in 8.0.5.

@Maoni0 can you have a look at the above?

from core.

leecow avatar leecow commented on June 8, 2024

Can we have link to what's the new feature released in 8.0.300, compared to 8.0.205, it should be a new feature release, so what's the new feature?

This versioning is primarily to enable new tooling work share with Visual Studio (ie compilers, analizers, msbuild, etc) to move forward with new versions of VS, though impactful SDK changes do sometimes also come into play.

@marcpopMSFT - who could help work out a good way to get this information into release notes or some other location?

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.