Comments (2)
Previously the tool loaded in 1252
https://github.com/carlossanlop/DocsPortingTool/blob/bcbb8d36dc3c4e264b2d37b063cdb737ba0e1796/Libraries/Docs/DocsCommentsContainer.cs#L179-L182
so I changed the save code to save in 1252 based on that comment
https://github.com/carlossanlop/DocsPortingTool/blob/bcbb8d36dc3c4e264b2d37b063cdb737ba0e1796/Libraries/Docs/DocsCommentsContainer.cs#L50-L51
I'm now unsure what is correct. @gewarren is asking. (UTF-8 everywhere would be wonderful)
from api-docs-sync.
Thanks for that. I chose that encoding because 99% of the xml files had that particular encoding.
Ideally (and I tried to do this in many ways) we would extract the original encoding of the file, and use that when loading the file, then when saving the file. Unfortunately, it wasn't as straighforward as I hoped: whenever a non-ascii character showed up, the XML APIs would either throw an unexpected exception, or the characters would get unexpectedly replaced with the square character □.
from api-docs-sync.
Related Issues (20)
- `<p></p>` elements in xml should be converted to `<para></para>`
- Remove `<inheritdoc />` if the tool ported documentation HOT 2
- Some crefs are not converted to xrefs in remarks HOT 3
- xml lists are not getting converted to markdown lists
- Conversion of see crefs to xrefs that contain backtick character is not working
- Implement `-PreserveInheritDocTag false` functionality
- Automatically add boilerplate summary for auto-added parameterless constructors
- Finding a null followed by a see cref ports them without space
- PortToTripleSlash issues found in unit tests HOT 1
- Simplify Roslyn whitespace handling, use autoformatting
- If a docs element is empty and can't be backported, don't remove it HOT 1
- restore fails with "Unable to find package Microsoft.DotNet.XUnitExtensions" HOT 1
- MsBuild failed processing csproj
- `<para></para>` elements should be in their own line
- Convert markdown to normal xml HOT 1
- Array.Copy Exception when running against System.Formats.Cbor HOT 3
- Some projects can't be ported immediately after building all runtime
- Missing item in dotnet-api-docs removes the existing item in triple slash
- PortToDocs fails and exits when encountering a malformed xml
- PortToTripleSlash might not be working with Microsoft.BCL assemblies
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from api-docs-sync.