Incompatible with apollo-server-plugin-base 0.7.1 about apollo-metrics

[tlaak]

The above did not work for me. I had to import the ApolloServerPlugin and do a type cast. There must be a type conflict.

import { register } from 'prom-client';
import createMetricsPlugin from 'apollo-metrics';
// This type works
import { ApolloServerPlugin } from 'apollo-server-plugin-base';

const apolloMetricsPlugin = createMetricsPlugin(
  register,
) as ApolloServerPlugin<Record<string, string>>;

[sdankel]

This happens in "apollo-server-plugin-base": "^0.9.0" as well

[phal0r]

Not only the typings are incompatible now. Also the latest prom-client returns a Promise when calling register.metrics(). As express does not handle promises, it won't work. Also I got compilation errors, where the default export of this plugin was not found with current Typescript version.

What I did, was to copy the sourecode and integrate it locally to my project.

My metrics handler looks like this:

app.get("/metrics", async (_, res) => {
    let data = await register.metrics()
    res.header('Content-Type', 'text/plain')
    res.send(data)
  });