[urql] should respect omitOperationSuffix and typesPrefix options about graphql-code-generator-community

[danielkcz]

@dotansimha So what about the typesPrefix? Do you have some answer to that, please? The issue got closed accidentally with the PR.

[ganonbit]

same issue with the plugin typescript-msw, it doesnt respect/acknolwedge omitOperationSuffix, even though the class its extending from class MSWVisitor extends visitorPluginCommon.ClientSideBaseVisitor has it listed as a config option. Was able to add it back manually but thats going to be a pain to manage a "custom" plugin that is fixed

[danielkcz]

So I decided to have a stab at this since it's starting to annoy me.

First thing, I noticed there is an explicit test to ignore typesPrefix. Why is that? Is that some opinion that it "looks ugly"? That certainly shouldn't be like that. If configured, it should be respected no matter what.

https://github.com/dotansimha/graphql-code-generator/blob/1ddabd70d424653f1e9b01819ede255b2cd0c53b/packages/plugins/typescript/urql/tests/urql.spec.ts#L591-L603

Same for components...

https://github.com/dotansimha/graphql-code-generator/blob/1ddabd70d424653f1e9b01819ede255b2cd0c53b/packages/plugins/typescript/urql/tests/urql.spec.ts#L455-L467

So what is the stance here? Changing this here is technically a breaking change if someone uses typesPrefix for something else.

[dotansimha]

Thanks, @FredyC , let's keep this open until we'll have a complete solution.

[danielkcz]

@dotansimha Solution is simple, but I need someone to decide what is the "correct behavior". Apparently, it was intended to ignore typesPrefix for some reason.