Coder Social home page Coder Social logo

Comments (9)

felipeelias avatar felipeelias commented on August 28, 2024

Couldn't reproduce. Just tested against ruby 1.8/1.9 and Rails 3.2.5 and doorkeeper 0.4.1

Is anyone else having this issue?

from doorkeeper.

jfrey avatar jfrey commented on August 28, 2024

I had some more time to look at this today and it appears to be working after a reinstall of the gem so perhaps an issue with my RVM or the initial install.

Apologies for the false alarm / inconvenience.

from doorkeeper.

jfrey avatar jfrey commented on August 28, 2024

Actually this is occurring when I specify a scope in my request. If I leave the scope blank it passes through correctly.

curl -i http://localhost:3000/oauth/token \
  -F grant_type=password \
  -F client_id=id \
  -F client_secret=secret \
  -F "scope=" \
  -F [email protected] \
  -F password=password

If I leave scope out or set it to scope= then it works as expected. When I set scope=public it fails. In my initializer I uncommented the default_scopes line.

Edit: I verified this in master as well.

from doorkeeper.

felipeelias avatar felipeelias commented on August 28, 2024

Ok. Makes sense. I'll investigate.

Thanks for taking your time debugging it.

from doorkeeper.

felipeelias avatar felipeelias commented on August 28, 2024

Can you test this branch please? https://github.com/applicake/doorkeeper/tree/password-scopes-fix

from doorkeeper.

jfrey avatar jfrey commented on August 28, 2024

Looks good, could your merge this into master as well?

from doorkeeper.

felipeelias avatar felipeelias commented on August 28, 2024

Yes, I'll update this today and release 0.4.2 version

from doorkeeper.

jfrey avatar jfrey commented on August 28, 2024

Great thanks!

from doorkeeper.

felipeelias avatar felipeelias commented on August 28, 2024

released 0.4.2 and updated master.

from doorkeeper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.