Coder Social home page Coder Social logo

Comments (13)

Donnnno avatar Donnnno commented on July 24, 2024 1

I think we're ready to close this now! 🎉

The new place to check out icon requests is from this site:
https://arcticons-team.github.io/Arcticons/requests.html

If you have any feedback, let us know :)

from arcticons.

TotallyAvailable avatar TotallyAvailable commented on July 24, 2024
  • As Yahoo Fantasy and DTS Sound should be the other way round (like many others) based on last request time, assuming it can be dropped, just sort by most requested following alphabetical order all the way down, or don't.... doesn't really matter ?
  • request_count -> rq_count/r_count
  • Maybe even drop the "item component=" part (appfilter: "ComponentInfo...) as the script can just "add" it if needed for comparing stuff. As for manually moving it into the appfilter with new icons...it's there, it's everywhere, at least 8 thousand times.
  • really pushing it: play.google.com/ -> play.google/

from arcticons.

petlyh avatar petlyh commented on July 24, 2024

I took a look at the email_parser.py script and it looks like the last request time is not used for sorting but is used for filtering old requests. Since that functionality also reduces the file size of the requests file (as well as the number of requests), removing the last request time is probably not a good idea after all.

request_count -> rq_count/r_count

I think it's important to maintain a certain level of human readability, so maybe abbreviations should be avoided.

Maybe even drop the "item component=" part (appfilter: "ComponentInfo...) as the script can just "add" it if needed for comparing stuff. As for manually moving it into the appfilter with new icons...it's there, it's everywhere, at least 8 thousand times.

I'm guessing that the requests file contains the full appfilter XML entry for each request to make it easier for contributors (especially new ones) to just copy it from the requests file without needing to understand it. That's why I kept it in the example structure.

really pushing it: play.google.com/ -> play.google/

That won't work since play.google links just redirect to the front page. Follow this link to see what I mean:
https://play.google/store/apps/details?id=com.donnnno.arcticons

from arcticons.

Kaiserdragon2 avatar Kaiserdragon2 commented on July 24, 2024

i also think the human readability is the most important thing. And with the suggested YAML format you wouldn't be able to just copy the the first to lines of an entry to copy it over into the appfilter.
Would would be the benefit of a machine readable file that is to be read be humans.
If you would only include links that work, this would be a benefit because you won't need to click one to find out nothing is there, but it would increase the runtime of the script. and without changing the format it would increase difficulty to re parse the file.

from arcticons.

Donnnno avatar Donnnno commented on July 24, 2024

What I like the most about the current txt file is the ability to copy and paste the name and component info really fast. It would be great to keep that in place with a new format.

from arcticons.

TotallyAvailable avatar TotallyAvailable commented on July 24, 2024

play.google not working as you would expect is a weird one. It certainly does for things that are not app listings (and knowing Google probably a few more factors playing into what actually works,when and where)...and how would you not take the opportunity to turn everything into .google, at least start forwarding 1:1.

Full filter entry and last requested staying, fair enough, that's what I'm here for. Ask and suggest from an outside view and what I'm personally comfortable "sacrificing".
Might start a discussion or be an outright 'no', the open source way.

from arcticons.

TotallyAvailable avatar TotallyAvailable commented on July 24, 2024

What I like the most about the current txt file is the ability to copy and paste the name and component info really fast. It would be great to keep that in place with a new format.

Picking up on it again.

How about turning it into somewhat of a page which allows for easy copying of the necessary filter info

like a code block

as well as just a simple click on one of the provided store links.
Search bar with suggestions/auto complete at the top and obviously not rendering the entire thing at once.

Cutting down on redundant and obsolete store links would obviously still be something of interest.

from arcticons.

Donnnno avatar Donnnno commented on July 24, 2024

Would probably be possible if we made a github.io or arcticons.com page for it I guess? But idk how we would do that

from arcticons.

Donnnno avatar Donnnno commented on July 24, 2024

Also, that got me thinking of a conversation from a while ago with Moertel (Retro icon pack & Candybar contributor), she made a small Arctic-manager like dashboard:

original

from arcticons.

TotallyAvailable avatar TotallyAvailable commented on July 24, 2024

Does certainly look quite interesting.

!Warning wild thoughts down below!

I would say it comes down to a few key points

  • request count/last request doesn't necessarily matter (can still be shown), likely as sort-by options
  • having the Icon (preview) directly available for a quick (comfort level) decision would be great
  • (somehow) grouping together likely similar/identical requests
  • A warning if a request is actually just a changed activity
  • A warning if the drawable is in conflict with an existing Icon
  • ideally a complete and correctly formatted appfilter entry with a <Copy> button
  • given that everything is going to be read only, an unique "entry identifier" which can be shared freely by contributors in an designated Issue/Discussion to avoid duplicates, point out issues or just ask for advice.
  • PR Template with <Copy> button -> Appname - (Identifier) - drawable. While the appfilter entries are obviously part of the PR, giving everyone a quick overview of which Icons not to work on (anymore) without having to manually create a list is great.
  • Checkbox to hide entries (done or unwanted) client side

Or just leave it as is. Worked for years (no idea how well of course). Maybe a "clean up" twice a year.

from arcticons.

Kaiserdragon2 avatar Kaiserdragon2 commented on July 24, 2024

I have something working https://kaiserdragon2.github.io/Arcticons/requests.html
@Donnnno
but i think we should open a different branch for the github page because the github action that i created would push to the main repo when a new pull request is opened or committed to an open one.
then the github action could push to the gh pages one

from arcticons.

Donnnno avatar Donnnno commented on July 24, 2024

Can do that once I'm back from my vacation! Anyways fantastic work. This is super useful for everyone :)

from arcticons.

Donnnno avatar Donnnno commented on July 24, 2024

@Kaiserdragon2 we have a new branch: https://github.com/Arcticons-Team/Arcticons/tree/icon-requests !

from arcticons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.