staticcheck: CheckDubiousSyncPoolSize needs a whitelist :( about go-tools

[dominikh]

To be honest I am inclined to remove the check. It does catch some unnecessary allocations, but so do go test and pprof... staticcheck, on the other hand, is a bit zealous about it, and has no way of telling if the allocations are really an issue or not (and we will not add annotations to teach it).

/cc @bradleyfalzon who implemented the check
/cc @dgryski who has experience with the check on an internal code base and could tell us how useful the check was

[bradleyfalzon]

Certainly if there's false positive, IMHO staticcheck should not continue the check, especially if it doesn't catch a major bug.

However, as the check is already marked as dubious, and if it's just a matter of excluding interfaces from the check, it looks straight forward to add an if condition (or add to the existing) checking the argument is not an interface using !types.IsInterface(arg.Value.Value.Type()) or similar, I'd be happy to PR that.

But it's then up to @dominikh if he wants to continue maintaining this.

For the record, implemented via dominikh/go-staticcheck#11 and discussed in dominikh/go-staticcheck#10 but the go vet inclusion discussion has more information golang/go#16311.

[dominikh]

I'll close this issue. The reported bug has been fixed, and we'll keep the check for now.