Coder Social home page Coder Social logo

Improve SetClass situation. about go-js-dom HOT 3 CLOSED

dominikh avatar dominikh commented on July 29, 2024
Improve SetClass situation.

from go-js-dom.

Comments (3)

dominikh avatar dominikh commented on July 29, 2024
  • I'll fix the documentation once I get a chance, thanks
  • We'll keep SetClass() around, purely because it's part of the DOM API. We may add documentation to point to Class(), however.
  • We will not merge Set and SetString – the implied semantic of SetString is that it allows passing in a space-separated list of tokens (as per the definition of a TokenList), so e.g. SetString("foo bar"). If we had something like Set("foo bar", "baz"), that might lead to confusion. Admittedly, the current Set already suffers that same issue ([]string{"foo bar", "baz"}), but we don't need to make it any worse.

from go-js-dom.

dmitshur avatar dmitshur commented on July 29, 2024

I am in agreement with your decision in points two and three for now, you provide convincing arguments.

Point one still needs to be addressed.

from go-js-dom.

dominikh avatar dominikh commented on July 29, 2024

@shurcooL Please review #17

from go-js-dom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.