Comments (1)
What level of config merging would we like to do here? I think top level property merging is an obvious requirement i.e.
// .dojorc
{
"extends": "./base-dojorc",
"build-app": {
"legacy": false,
"build-time-render": {
// stuff
}
}
}
// .base-dojorc
{
"pwa": {
"manifest": {...},
}
}
// Results in:
{
"extends": "./base-dojorc",
"build-app": {
"legacy": false,
"build-time-render": {
// stuff
}
}
"pwa": {
"manifest": {...},
}
}
However, if we have matching top level properties like so, how would we expect this to behave?
// .dojorc
{
"extends": "./base-dojorc",
"build-app": {
"legacy": false,
"build-time-render": {
// child properties
}
}
}
// .base-dojorc
{
"build-app": {
"legacy": true,
"build-time-render": {
// child properties
}
"proxy": {
// child properties
}
}
// Results in?
Here the question is should it completely replace the whole build-app
top level property, or should it try and merge it's child properties? If so, do we merge all the way down the tree or do we stop at the first level of children?
To me a sensible output for this situation would be :
{
"extends": "./base-dojorc",
"build-app": {
"legacy": false,
"build-time-render": {
// .dojorc "build-time-render" properties
}
"proxy": {
// .base-dojorc "proxy" properties
}
}
}
from cli.
Related Issues (20)
- Bug: RenderFiles creates a directory with the name of the file that needs to be rendered
- Dojo CLI will return help for none existent commands
- Type mistmatch between return types of ValidateHelper and validate
- Startup time of dojo CLI is high HOT 9
- Unknown arguments could be more apparent
- dojo eject hangs on Windows 10 HOT 5
- Issue with offline dojo and host resolve HOT 4
- Update README HOT 1
- Support for custom `.dojorc` configuration file
- dojo version doesn't list installed commands
- dojo init not writing entries
- New `config` option conflicts with other commands
- Support force with the schema validation
- The `dojorc` init is not working properly for installed commands HOT 2
- Using "global" cli args in .dojorc file throws
- Successfully wrote undefined to <directory>
- CLI does not explicitly exit when a command is ran successfully
- When using "base" in dojo.rc, references to webfonts in /assets are not adjusted
- Libts problem on Fedora 37 Beta
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cli.