Coder Social home page Coder Social logo

Comments (1)

JamesLMilner avatar JamesLMilner commented on May 24, 2024

What level of config merging would we like to do here? I think top level property merging is an obvious requirement i.e.

// .dojorc
{
  "extends": "./base-dojorc",
  "build-app": {
    "legacy": false,
    "build-time-render": {
       // stuff
     }
  }
}

// .base-dojorc
{
  "pwa": {
    "manifest": {...},
  }
}

// Results in:

{
  "extends": "./base-dojorc",
  "build-app": {
    "legacy": false,
    "build-time-render": {
       // stuff
     }
  }
  "pwa": {
    "manifest": {...},
  }
}

However, if we have matching top level properties like so, how would we expect this to behave?

// .dojorc
{
 "extends": "./base-dojorc",
  "build-app": {
    "legacy": false,
    "build-time-render": {
       // child properties
     }
  }
}


// .base-dojorc
{
  "build-app": {
    "legacy": true,
    "build-time-render": {
        // child properties
     }
     "proxy": {
        // child properties
    }
}

// Results in?

Here the question is should it completely replace the whole build-app top level property, or should it try and merge it's child properties? If so, do we merge all the way down the tree or do we stop at the first level of children?

To me a sensible output for this situation would be :

{
 "extends": "./base-dojorc",
  "build-app": {
    "legacy": false,
    "build-time-render": {
       // .dojorc "build-time-render" properties
     }
    "proxy": {
        // .base-dojorc "proxy" properties
     }
  }
}

from cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.