[d3d9] : GTA San Andreas Crash about dxvk

[K0bin]

Thanks for staying persistent and for the excellent work on the bisect!

[Blisto91]

Yea thank you for the bisect.
The reason we were very much suspecting a Intel driver issue is that we don't have a GPU to test on ourselves and it worked with other drivers seemingly. The Intel Windows driver also don't always have a great history with this dxvk and the backtrace was looking weird.
Just one of those extra annoying bugs heh.

[niresh1234]

Please try that PR once CI is done building it.

Hey @K0bin .........Now It's working...... Great👍👍

[mirh]

To be fair, working with D3D9On12 bugs is usually more pleasant than the average because it's completely open source.

[Blisto91]

Do you use any addons since you mention ultimate asi loader.

[niresh1234]

@Blisto91 actually i also test game without any addon also... but still crash sins artifacts https://github.com/doitsujin/dxvk/actions/runs/9804878804 to v2.4

and important
my heavily modded GTASA game works fine before this commit artifacts
from v2.3.1 to https://github.com/doitsujin/dxvk/actions/runs/9804865813

you can see this two commit in top post image..... so you can find problem where start...

[Blisto91]

Could you give some information about your setup such as GPU, Operating system, logs and maybe a apitrace if possible?
I tried starting the game here with 2.4+ but i am not seeing a crash so far. Testing on Nvidia.

Edit: Actually from the backtrace i can gather you are using Intel Windows?

[niresh1234]

@Blisto91

Im on Windows, I know dxvk mainly devloped for linux..

Here are some details:

• OS: Windows 10 22H2 (up-to-date)
• CPU: Intel i5-12400
• GPU: Intel UHD-730 (integrated)
• Driver: Latest 5762

.
.
.
.
Now read this (what all things happened):

My Heavily modded GTA-SA game fully working without any issue in DXVK v2.3.1......

Recently DXVK v2.4 update release, so I replace dxvk 32bit d3d9.dll to v2.4 d3d9.dll

and now my game crash at loading screen (load save game).... or game crash after first cutsceen (new game).....

Then I again try v2.3.1 and game started working again perfectly.....

So I go to dxvk GitHub actions page (master, artifacts) and try artifacts one by one sins release v2.3.1 and find this two artifacts
where one is working - [d3d9] Fix DF Formats selection logic
and one is crash [d3d9] Reduce data copied for SWVP vertex decls

Hare screenshot attached of GitHub actions artifacts...

[Blisto91]

Ok.
I tried starting a new game on AMD both with radv and amdvlk (Linux both) but still haven't gotten it to crash.

[niresh1234]

@Blisto91 now checked again with Clean GTA-SA (without modified any file or any plugin)

this is full log file
working - dxvk-master-5ae3cfe40200cb716ea78a2b02b8b4a11b1b3432.zip.log
crash - dxvk-master-bbe851f6a25b57f320362c97b12afc52bfa99da1.zip.log

Comparision of two commits were actually problem started.
Click here 👉👉 5ae3cfe...bbe851f

[koffiato]

Can't reproduce on RX 6700 XT @ 24.6.1 proprietary drivers on Windows unfortunately.

[K0bin]

Can't reproduce. Might be an Intel driver issue.

[mirh]

0x6EDDA93E Direct3DCreate9On12Ex+0x890fe in d3d9.dll (+0x8a93e)

This sounds like an incompatibility with d3d9on12 (which I thought Intel had stopped to use, but go figure)
If you have ACT/ADK installed, you might want to try to replicate with D3D9On12Enabler -On

[niresh1234]

and @koffiato @Blisto91 @doitsujin

@mirh intel remove native d3d9 support from 12th gen+ cpus iGPU (which i used) and arcGPU, and use d3d9on12 for these...

@K0bin how to show this info? which software?

.
.
.
.
I think, the issue only able to reproduce when using d3d9on12 forcefully or in the hardware which is not supported d3d9 natively (like 12th gen+ CPUS iGPU or intel arcGPU).... i think @mirh is find something...

[K0bin]

intel remove native d3d9 support from 12th gen+ cpus iGPU (which i used) and arcGPU, and use d3d9on12 for these...

That's irrelevant. You're trying to use DXVK, not whatever Intel decided to use as their D3D9 driver.

[niresh1234]

@K0bin how to show this info on-screen?

[K0bin]

Show what info on screen?

And yes, I can play the game just fine with DXVK.

Something in the Intel Windows driver stack breaks DXVK. If you want to use DXVK, it's gonna work just fine on Linux, even with an Intel GPU.

[Blisto91]

It is probably better to report the issue to Intel yes.

[niresh1234]

Something in the Intel Windows driver stack breaks DXVK. If you want to use DXVK, it's gonna work just fine on Linux, even with an Intel GPU.

then how DXVK v2.3.1 works fine without issue?
.
.
.
.
.

Show what info on screen?

this

[Blisto91]

Try to make an issue here if they accept ones with dxvk manually applied and see if they come up with something https://github.com/IGCIT/Intel-GPU-Community-Issue-Tracker-IGCIT

[K0bin]

then how DXVK v2.3.1 works fine without issue?

Because 2.3.1 worked slightly differently and the driver was okay with that. That doesn't make what we're doing now any less correct.

[mirh]

That's irrelevant. You're trying to use DXVK, not whatever Intel decided to use as their D3D9 driver.

It is still somehow relevant tbh. D3d9on12 doesn't replace the directx runtime, it's a fully fledged driver.

Because 2.3.1 worked slightly differently and the driver was okay with that. That doesn't make what we're doing now any less correct.

Yeah, considering #3895 addressed some wine tests it's more likely microsoft botched something...
On the other hand the driver is crashing inside of the vulkan dll, not the dx12 UMD.

@niresh1234 you should try to report the issue over at https://github.com/microsoft/D3D9On12/issues
EDIT: and if you don't have access to a compiler to try to individually revert those commits, you could check if one of these older check runs gives you more luck

[niresh1234]

Hey @mirh @K0bin

I try to compile old commits one by one..... and then test....

and find this commit where exactly problem start... da81466 **Its only one-line code added**

👉 I just comment-out this line and compile and try....... and Latest-DXVK now working...
see what I change 👉 niresh1234@8982763

Note: I do not have C++ knowledge... so not saying this commit/line is wrong.... but actually, problem start from there... and issue resolve for me if i comment-out/remove these line and compile

[K0bin]

Nice, there's indeed a bug in that line.

[K0bin]

Please try that PR once CI is done building it.

[niresh1234]

Please try that PR once CI is done building it.

Sure! I will check