Class constructor Renderer cannot be invoked without 'new' about highway

[Anthodpnt]

@wassim

I'm happy to announce that the latest release v1.3.6 now provides an ES5 version of Highway.
Please give it a try and keep us informed about your issue.

Best regards,
Anthodpnt

[Anthodpnt]

Hi @wassim,

Highway comes in ES6 and I pretty sure it's not compiled through babel maybe because you are ignoring the node_modules which result in your code being compiled in ES5 mixed with Highway that remains in ES6.

Please check out the basic-polyfill example that should help you change your configuration in order to include Highway in the compilation process. This is an example using the babel-loader through Webpack.

This is our will to keep Highway in ES6 but we will consider providing an ES5 version to avoid this kind of repetitive issues 😃. Until then please keep us informed if this solution fixed your issue.

Best regards,
Anthodpnt

[Anthodpnt]

@wassim The problem don't really come from Highway but from your ESLint configuration that make the compilation fails on errors and that's not a good practice IMO.

If you change the version in order to support latest features of ECMAscript and disable the fail on error option or something you should be able to at least finish your compilation properly...

On our side we are considering an ES5 version of Highway that might come very soon.

[wassim]

@Anthodpnt thanks. Indeed I was ignoring the node_modules/@Dogstudio. Now eslint isn't happy 😭

error  in ./node_modules/@dogstudio/highway/dist/highway.js

Module build failed:
232 :    *
233 :    * @return {object} Promise
234 :    */
235 :   show() {
236 :     return new Promise(async resolve => {
                                   ^
Unexpected token (236:29) 

I saw that you are using eslint as well, are you linting successfully?

[Anthodpnt]

@wassim

I don't know how you configured your .eslintrc file but apparently it doesn't support async/await and returns errors. Maybe you should consider changing the ecmaVersion to 2018 or checkout the configuration we have for Highway.

[wassim]

Couldn't pass through the multiple errors I'm getting. Would love to see a compiled es5 version.

[wassim]

Thanks! Working nice now 👌

[Anthodpnt]

Perfect ! Closing the issue then...