DBAL-11: Improve API of Sqllogger about dbal

[doctrinebot]

Comment created by romanb:

Yea, its currently a known limitation that the times do not get logged. However, I have real doubts as to whether that is actually useful as such measurements from PHP are very inaccurate. Its much better to copy+paste a SQL query to a SQL console and run it with ANALYZE/EXPLAIN ... to see its performance.

sfDoctrine2Plugin already uses this logger for its debug toolbar.

[doctrinebot]

Comment created by @hobodave:

Such timings are very useful. The accuracy isn't really the point. If you have N queries executing on a slow request, you have to check N queries to find the problem. With a simple "inaccurate" time measurement you'd be able to quickly identify the problem query(ies) and take further action.

[doctrinebot]

Comment created by romanb:

I think timings can be added.

[doctrinebot]

Comment created by @beberlei:

Schedule for BETA 3

[doctrinebot]

Comment created by @beberlei:

Implemented this change, the interface of the SQL Logger changed to:

function logSQL($sql, array $params = null, $executionMS = null);

Additionally the contract of loggers changed, they are now invoked AFTER a query is executed therefore queries that cause failures do not appear on the logs.

[doctrinebot]

Issue was closed with resolution "Fixed"

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.