tag rm on non existent repo not helpful about hub-tool

[thaJeztah]

I would suggest;

• (if possible); check if the repo exists before prompting, and print a error "tag/image foo:bar does not exist"
• For removing a single tag, perhaps a [yN] is sufficient (I can see having to type the whole name being more useful for removing a whole repository (if it has multiple tags)
• --force should just do that; remove if exists, and ignore if it was found already (same as rm -f nosuchfile ignores non-existing files/directories)

For the warning printed, make it more clear that it's a destructive operation; something like

WARNING: you are about to permanently delete foo:bar.
This operation cannot be reversed!
Are you sure you want to continue? [yN] 

[chris-crone]

Looks like the same issue exists for repo rm. I'm working out how best to fix this (i.e.: in the client or in the CLI)

[spkane]

When using -f the command should really exit with exit code 0, if the tag does not exist, so that this can easily be used in automation.

hub-tool tag rm -f user/tool:tag

Maybe with something like this:

diff -ur hub-tool/internal/commands/tag/rm.go hub-tool-envlogin/internal/commands/tag/rm.go
--- hub-tool/internal/commands/tag/rm.go	2022-01-05 13:04:09.000000000 -0800
+++ hub-tool-envlogin/internal/commands/tag/rm.go	2022-01-05 13:04:58.000000000 -0800
@@ -96,7 +96,12 @@
 	}

 	if err := hubClient.RemoveTag(reference.FamiliarName(ref), ref.Tag()); err != nil {
-		return err
+		if strings.Contains(err.Error(), "404 NOT FOUND") {
+			fmt.Fprintln(streams.Out(), "Not Found", image)
+			return nil
+		} else {
+			return err
+		}
 	}
 	fmt.Fprintln(streams.Out(), "Deleted", image)
 	return nil