docker-py doesn't work with Docker 0.5.2 default configuration about docker-py

[keeb-zz]

I've started working on a unix socket patch to requests which will allow this to work.

[keeb-zz]

Some minor notes so far. The goal will be to reuse as much of the HTTPAdapter as possible and only patch in the places that need to change. Requests is pretty modular, but has pretty complicated connectionpool logic.

requests.Session has a mount method that allows for custom protocol handlers to be registered with an associated adapter.

My thinking is that inheriting and initializing the requests.adapter.HTTPAdapter and overwriting the get_connection method is the least invasive way to do it.

[keeb-zz]

See attached patch for a WIP: https://gist.github.com/keeb/bf39ef50677d4b2ae3dd

The biggest hurdle right now is that there is no reliable way to separate a unix socket file from the rest of the parameter string. Separating the two would mean that we'd have to change the interface, which is something I would like to avoid if at all possible.

This would be trivial if we did not use requests but instead used httplib directly.

Thoughts?

[kstaken]

How far along should the patch get? I get the error below but I'm guessing maybe that's expected at this stage.

requests.exceptions.InvalidURL: Invalid URL u'unix:///var/run/docker.sock/v1.4/containers/create': No host supplied

[keeb-zz]

@kstaken - it's a little backward, but the problem is the URL you're passing in to the client. It should be unix://var/run/docker.sock (notice, only 2 /'s)

a simple test is

import docker
c = docker.Client(base_url="unix://var/run/docker.sock")
print c.version()

[kstaken]

@keeb the URL came from your patch. The default base_url :-)

And wouldn't 3 slashes actually be correct anyway? unix:// is the scheme and then the path is /var/run/docker.sock although it seems maybe that wouldn't work with requests.

[kstaken]

@keeb do commands other than c.version() work for you?

[kstaken]

oh, I see _extract_path is just hard coded to return /version at the moment.

[keeb-zz]

Patch incoming..

[shin-]

Thanks @keeb !